vfprintf(3): Add support for kernel %b format
ClosedPublic
Actions

Authored by cem on Nov 3 2016, 12:50 AM.

Details

Reviewers

emaste
jilles

Commits

rS310138: vfprintf(3): Add support for kernel %b format

Summary

This is a direct port of the kernel %b format.

I'm unclear on if (more) non-portable printf extensions will be a problem. I
think it's desirable to have userspace formats include all kernel formats, but
there may be competing goals I'm not aware of.

I think das@ should review this as the most heavy printf committer, but they
don't appear to have a phabricator account.

Test Plan

#include <stdio.h>
void main(void) {
        printf("%b\n", 0x12345, "\20\01low\02med\21hi");
}

Should print: 12345<low,hi>

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5825
Build 6114: arc lint + arc unit

Event Timeline

cem updated this revision to Diff 21958.Nov 3 2016, 12:50 AM

cem retitled this revision from to vfprintf(3): Add support for kernel %b format.

cem updated this object.

cem edited the test plan for this revision. (Show Details)

cem added reviewers: emaste, jilles.

I think there are lots of reasons we'd like to compile and use kernel code in userspace and having %b be available is certainly useful for that. On the other hand, if this becomes widely used in FreeBSD userland code it makes it harder to use that code in other projects or possibly build FreeBSD on other hosts.

Do you have an example use case in mind?

In D8426#175349, @emaste wrote:

I think there are lots of reasons we'd like to compile and use kernel code in userspace and having %b be available is certainly useful for that. On the other hand, if this becomes widely used in FreeBSD userland code it makes it harder to use that code in other projects or possibly build FreeBSD on other hosts.

Yep!

Do you have an example use case in mind?

Yeah. At $WORK we've got an on-disk structure that is manipulated by userspace. It's got a few flags fields. We have a tool that prints out the on-disk structure in a human readable format. It'd be convenient to use %b, rather than re-implement %b, in that tool.

(I guess we ($WORK) could always carry it as a local libc patch — it's very self-contained. But I prefer not to do that if possible.)

Any strong objection to this?

Closed by commit rS310138: vfprintf(3): Add support for kernel %b format (authored by cem). · Explain WhyDec 16 2016, 1:45 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

lib/

libc/

stdio/

vfprintf.c

31 lines

Diff 21958

View Options

vfprintf(3): Add support for kernel %b formatClosedPublicActions