net/concourse-fly: New port for Concourse's CLI
ClosedPublic
Actions

Authored by dumbbell on Sep 7 2016, 9:10 PM.

Details

Reviewers

swills
kwm
mat

Commits

rP424940: net/concourse-fly: New port for Concourse's CLI

Summary

Beside comments on the port itself, I'm wondering what would be the
best category. fly is a tool to access a remote Concourse deployment.
Concourse itself is a CI system, just like Jenkins.

Furtnermore, the CLI is called fly. Unfortunately, there is another
port, graphics/fly, which already installs a command with the same
name. I would like to keep the fly name because it's the name used in
Concourse documentation and I would like the experience to be flawless
to the end-user (the ultimate goal would be to package Concourse
itself). How is this kind of conflict resolved usually?

Test Plan

I ran Poudriere for 11-CURRENT/amd64 and 9.3-RELEASE/amd64. I also
built the port locally on 12-CURRENT/amd64 and used it at work.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 5745
Build 6045: arc lint + arc unit

Event Timeline

dumbbell updated this revision to Diff 20153.Sep 7 2016, 9:10 PM

dumbbell retitled this revision from to net/concourse-fly: New port for Concourse's CLI.

dumbbell updated this object.

dumbbell edited the test plan for this revision. (Show Details)

dumbbell added reviewers: kwm, swills.

Herald added a subscriber: mat. · View Herald TranscriptSep 7 2016, 9:10 PM

mat added inline comments.Sep 8 2016, 7:44 AM

net/concourse-fly/Makefile
6	This is out of order, and in that case, better do: PORTNAME=concourse PKGNAMESUFFIX= -fly
24–45	This is a great description of what you are doing, but this is not how we do things, the way we do things is explained in the porter's handbook: https://www.freebsd.org/doc/en/books/porters-handbook/makefile-distfiles.html#makefile-master_sites-github-submodules

dumbbell added inline comments.Sep 8 2016, 10:09 AM

net/concourse-fly/Makefile
6	Just to be clear, this port is about the CLI only, not the entire Concourse. So if Concourse is packaged one day, they will not conflict, right? With your suggestion, this port will still be named "concourse-fly" but there will be no need to override `DISTNAME`, correct?
24–45	I read that example before doing that. As far as I understand, the example only supports repositories hosted on GitHub. However, Concourse uses Git submodules hosted elsewhere too. I will add a comment about that to explain why the example from the Porter's handbook couldn't be applied here.