Page MenuHomeFreeBSD
Differential D8325

Fix installworld with WITHOUT_DIALOG
ClosedPublic
Actions

Authored by bapt on Oct 22 2016, 4:22 PM.
Tags
None
Referenced Files
F166580238: D8325.id21619.diff
Fri, Aug 14, 5:07 PM
Unknown Object (File)
Sat, Aug 8, 6:45 PM
Unknown Object (File)
Wed, Aug 5, 10:54 PM
Unknown Object (File)
Sat, Jul 18, 9:42 PM
Unknown Object (File)
Jul 4 2026, 5:56 PM
Unknown Object (File)
Jul 3 2026, 1:08 PM
Unknown Object (File)
Jul 3 2026, 12:47 PM
Unknown Object (File)
Jul 2 2026, 10:10 PM
View All Files
Subscribers
imp

Details

Reviewers
emaste
Summary

Fix installationn WITHOUT_DIALOG by building tzsetup without the dialog support

Diff Detail

Event Timeline

bapt updated this revision to Diff 21618.Oct 22 2016, 4:22 PM
bapt retitled this revision from to Fix installworld with WITHOUT_DIALOG.
bapt updated this object.
bapt edited the test plan for this revision. (Show Details)
bapt added a reviewer: emaste.
Herald added a subscriber: imp. · View Herald TranscriptOct 22 2016, 4:22 PM
bapt updated this revision to Diff 21619.Oct 22 2016, 4:31 PM

Add one missing ifdef HAVE_DIALOG

bapt updated this revision to Diff 21624.Oct 22 2016, 10:30 PM

Collapse the HAVE_DIALOG as much as possible

emaste accepted this revision.Oct 22 2016, 10:30 PM
emaste edited edge metadata.

I think this is OK. I'd like to reduce the number of #ifdef HAVE_DIALOG blocks if we could, but we can iterate on that.

This revision is now accepted and ready to land.Oct 22 2016, 10:30 PM
emaste added a comment.Oct 22 2016, 10:32 PM

Ah, your update and my comment crossed paths. Thanks, I like this better.

bapt closed this revision.Oct 22 2016, 11:52 PM

rS307802

Revision Contents
Changeset List

PathSize
tools/
build/
mk/
2 lines
usr.sbin/
2 lines
tzsetup/
8 lines
154 lines

Diff 21624

View Options

tools/build/mk/OptionalObsoleteFiles.inc

Loading...
View Options

usr.sbin/Makefile

Loading...
View Options

usr.sbin/tzsetup/Makefile

Loading...
View Options

usr.sbin/tzsetup/tzsetup.c

Loading...