Page MenuHomeFreeBSD

Fix ip_output() on point-to-point links
ClosedPublic

Authored by rstone on Oct 20 2016, 6:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 10, 4:29 AM
Unknown Object (File)
Mon, Nov 10, 3:44 AM
Unknown Object (File)
Thu, Nov 6, 3:17 AM
Unknown Object (File)
Tue, Nov 4, 12:49 AM
Unknown Object (File)
Mon, Nov 3, 2:22 PM
Unknown Object (File)
Sun, Oct 26, 5:28 PM
Unknown Object (File)
Sun, Oct 19, 11:06 AM
Unknown Object (File)
Sep 25 2025, 3:05 AM
Subscribers

Details

Summary

In r304435, ip_output() was changed to use the result of the route
lookup to decide whether the outgoing packet was a broadcast or
not. This introduced a regression on interfaces where
IFF_BROADCAST was not set (e.g. point-to-point links), as the
algorithm could incorrectly treat the destination address as a
broadcast address, and ip_output() would subsequently drop the
packet as broadcasting on a non-IFF_BROADCAST interface is not
allowed.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5665
Build 5949: arc lint + arc unit

Event Timeline

rstone retitled this revision from to Fix ip_output() on point-to-point links.
rstone edited the test plan for this revision. (Show Details)
rstone added a reviewer: transport.
rstone updated this object.
jtl added a reviewer: jtl.
This revision is now accepted and ready to land.Oct 20 2016, 6:53 PM
This revision was automatically updated to reflect the committed changes.