Page MenuHomeFreeBSD
Differential D8150

pInterp is no longer needed
ClosedPublic
Actions

Authored by imp on Oct 4 2016, 9:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 5, 11:02 AM
Unknown Object (File)
Thu, Nov 28, 6:00 AM
Unknown Object (File)
Nov 27 2024, 12:18 AM
Unknown Object (File)
Nov 26 2024, 3:51 AM
Unknown Object (File)
Nov 23 2024, 3:57 AM
Unknown Object (File)
Nov 16 2024, 1:18 PM
Unknown Object (File)
Nov 11 2024, 11:34 AM
Unknown Object (File)
Nov 10 2024, 10:05 PM
View All 79 Files
Subscribers
None

Details

Reviewers
dteske
emaste
tsoome
Commits
rS307323: Remove fetching of pInterp. Currently, there's no actual effect other
Summary
Remove fetching of pInterp. As near as I can tell, this never had any
actual effect other than to store the location of a forth word that
was subsequently never used. It was last used before the 2.03 ficl
upgrade in r51786. It was only used from r43614 (so Feb-Sept 1999) on
head and in the 3.x branch (merged r43715 3.1 -> EOL). Remove it since
nobody cared enough to report the bug in the last 18 years rather than
fix it. It's need seems to have passed in the 2.03 ficl update.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 5453
Build 5664: CI src buildJenkins

Event Timeline

imp updated this revision to Diff 21047.Oct 4 2016, 9:07 PM
imp retitled this revision from to pInterp is no longer needed.
imp updated this object.
imp edited the test plan for this revision. (Show Details)
imp added reviewers: dteske, tsoome, emaste.
imp set the repository for this revision to rS FreeBSD src repository - subversion.
emaste edited edge metadata.Oct 4 2016, 9:12 PM

Is this diff backwards?
Also no context :(

imp added a comment.Oct 4 2016, 9:14 PM

This diff is actually backwards.

imp updated this revision to Diff 21048.Oct 4 2016, 9:15 PM
imp edited edge metadata.
imp removed rS FreeBSD src repository - subversion as the repository for this revision.

Ooops, generate diff the right way.

tsoome accepted this revision.Oct 4 2016, 9:31 PM
tsoome edited edge metadata.

I was wandering about what the background there, so thanks for history lesson;)

This revision is now accepted and ready to land.Oct 4 2016, 9:31 PM
emaste accepted this revision.Oct 6 2016, 1:34 AM
emaste edited edge metadata.
Closed by commit rS307323: Remove fetching of pInterp. Currently, there's no actual effect other (authored by imp). · Explain WhyOct 14 2016, 4:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
boot/
common/
6 lines

Diff 21047

View Options

sys/boot/common/interp_forth.c

Loading...