Refine the dirname(3) compatibility workaround a bit more.
ClosedPublic
Actions

Authored by ed on Sep 9 2016, 7:18 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Apr 28, 4:29 AM

	Unknown Object (File)
	Sat, Apr 25, 7:01 AM

	Unknown Object (File)
	Thu, Apr 23, 1:18 AM

	Unknown Object (File)
	Thu, Apr 23, 12:57 AM

	Unknown Object (File)
	Tue, Apr 21, 6:46 PM

	Unknown Object (File)
	Tue, Apr 21, 8:02 AM

	Unknown Object (File)
	Tue, Apr 21, 7:49 AM

	Unknown Object (File)
	Tue, Apr 21, 2:49 AM

View All Files

Subscribers

imp

Details

Reviewers

emaste
madpilot
bdrewery

Commits

rS306100: Refine the dirname(3) compatibility workaround a bit more.

Summary

Right now our workaround is so good that it doesn't throw any warnings
on misuse. This means that people will keep on using the old version
of dirname(3) silently without fixing their code.

Go ahead and change the prototype of __old_dirname() to also use a plain
char *, so that we still get a compiler warning.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ed updated this revision to Diff 20234.Sep 9 2016, 7:18 PM

ed retitled this revision from to Refine the dirname(3) compatibility workaround a bit more..

ed updated this object.

ed edited the test plan for this revision. (Show Details)

ed added reviewers: bdrewery, madpilot.

Herald added a subscriber: imp. · View Herald TranscriptSep 9 2016, 7:18 PM

ed added a reviewer: emaste.Sep 13 2016, 4:28 PM

Friendly ping. :-)

Closed by commit rS306100: Refine the dirname(3) compatibility workaround a bit more. (authored by ed). · Explain WhySep 21 2016, 1:04 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

include/

libgen.h

4 lines

Diff 20579

View Options

Refine the dirname(3) compatibility workaround a bit more.ClosedPublicActions