intended?

It seems src.opts.mk is most often included at the top of the Makefile

Agreed. This looks incorrect, potentially. If there's an issue with ordering of the subdirectories, it should be:

SUBDIR_PARALLEL=
SUBDIR_DEPEND_services=libcasper

Make sure LIBDIR is correct though before doing that to avoid incorrectly installing it to /usr/lib .

Please use

dns_test

errx(1, "...");

?

(Picking a random item)

These hardcoded addresses/ports should really be #defines.

What if this happens? Should the test exit?

Also, what happens if the kernel was compiled with !INET?

Uhhhhhhh... why 25 (smtp)? Some IT groups might specifically block port 25. Is there an alternate port that can be used?

Also, this could use "getservbyname" for clarity.

Bleh.. I don't like this assumption.

Check the result of inet_pton?

Same comments as above.

grp_test please.

Ew? Is there a better way we could be using than this?

Why is the return value of this function being ignored?

Same as above.

Hardcoded group names... should be #defines.

nitems(cmds) - 1 instead of 7?

nitems(names) - 1

Use

nitems(...) - 1

here?

sysctl_test ?

Can these subtests please be broken down a bit further (even if they're in separate functions)? It'll make converting them to ATF much easier..