make logout_req::reason an unsigned char to fix warning setting bit 7
ClosedPublic
Actions

Authored by emaste on Aug 29 2016, 7:51 PM.

Details

Reviewers

scottl
dim
trasz

Commits

rS310544: MFC r305078 (by emaste):
rS305078: iscsi_initiator: make logout_req::reason unsigned char

Summary

Based on context it appears reason should be an unsigned 8-bit field.

/tank/emaste/src/freebsd-clang-import/sbin/iscontrol/fsm.c:612:25: error: implicit conversion from 'int' to 'char' changes value from 128 to -128 [-Werror,-Wconstant-conversion]
     p->reason = BIT(7) | 0;
               ~ ~~~~~~~^~~
1 error generated.
*** [fsm.o] Error code 1 (ignored)

Oddly I can't find any user of logout_req(_t)? other than the one in sbin/iscontrol/fsm.c

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste updated this revision to Diff 19800.Aug 29 2016, 7:51 PM

emaste retitled this revision from to make logout_req::reason an unsigned char to fix warning setting bit 7.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste added reviewers: dim, trasz.

It looks good to me, but I'm not sure if there are other consumers of this header, which rely on the fields? Then again, u_char is clearly the right type here.

Closed by commit rS305078: iscsi_initiator: make logout_req::reason unsigned char (authored by emaste). · Explain WhyAug 30 2016, 7:20 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

iscsi_initiator/

iscsi.h

2 lines

Diff 19853

View Options

head/sys/dev/iscsi_initiator/iscsi.h

make logout_req::reason an unsigned char to fix warning setting bit 7ClosedPublicActions