Check all compatible strings on uart devices in powerpc
ClosedPublic
Actions

Authored by jhibbits on Aug 28 2016, 7:01 PM.

Details

Reviewers

nwhitehorn
andrew

Commits

rS308373: MFC r304970:
rS304970: Check all compatible strings on uart devices in powerpc

Summary

Some device trees put "fsl,ns16650" first in the compatible list. This causes
the probe code to choke, even though the device is compatible with ns16650, and
has it listed later in the tree.

Test Plan

Boot the kernel

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4959
Build 5024: arc lint + arc unit

Event Timeline

jhibbits updated this revision to Diff 19762.Aug 28 2016, 7:01 PM

jhibbits retitled this revision from to Check all compatible strings on uart devices in powerpc.

jhibbits updated this object.

jhibbits edited the test plan for this revision. (Show Details)

jhibbits added reviewers: andrew, nwhitehorn.

Herald added a subscriber: imp. · View Herald TranscriptAug 28 2016, 7:01 PM

You might want to also look at how we find the correct uart in uart_bus_fdt.c. We have a linker set to enumerate all drivers we support. They then provide a struct ofw_compat_data with the compat string and uart class.

Add a new ofw_bus_ function. This reuses the existing name of an
internal(static) function, and renames the static function to _int (couldn't
think of a better name).

In D7676#159503, @andrew wrote:

You might want to also look at how we find the correct uart in uart_bus_fdt.c. We have a linker set to enumerate all drivers we support. They then provide a struct ofw_compat_data with the compat string and uart class.

Right, uart_cpu_powerpc.c's getdev() should be getting called by way of uart_bus_fdt.c.

Looks good. Thanks!

This revision is now accepted and ready to land.Aug 28 2016, 9:27 PM

Closed by commit rS304970: Check all compatible strings on uart devices in powerpc (authored by jhibbits). · Explain WhyAug 28 2016, 9:31 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

dev/

uart/

uart_cpu_powerpc.c

6 lines

Diff 19762

View Options

sys/dev/uart/uart_cpu_powerpc.c

Check all compatible strings on uart devices in powerpcClosedPublicActions