Page MenuHomeFreeBSD
Differential D938

Don't check M_EXT on mbufs returned by m_getjcl()
ClosedPublic
Actions

Authored by rwatson on Oct 12 2014, 4:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Aug 18, 7:13 PM
Unknown Object (File)
Thu, Aug 14, 9:30 AM
Unknown Object (File)
Thu, Jul 31, 4:54 PM
Unknown Object (File)
Jul 15 2025, 3:33 PM
Unknown Object (File)
Jul 5 2025, 8:31 PM
Unknown Object (File)
Jul 4 2025, 4:36 PM
Unknown Object (File)
Jun 29 2025, 12:19 AM
Unknown Object (File)
Jun 22 2025, 6:05 AM
View All Files
Subscribers
rpaulo

Details

Reviewers
glebius
bz
Commits
rS273028: Eliminate unnecessary checking for M_EXT on mbufs returned by m_getjcl().
Summary

Remove unnecessary tests for m_getjcl() returning an mbuf without a cluster attached: it will either return an mbuf with a cluster, or NULL on failure.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

rwatson updated this revision to Diff 1967.Oct 12 2014, 4:54 PM
rwatson retitled this revision from to Don't check M_EXT on mbufs returned by m_getjcl().
rwatson updated this object.
rwatson edited the test plan for this revision. (Show Details)
rwatson added reviewers: bz, glebius.
rwatson set the repository for this revision to rS FreeBSD src repository - subversion.
bz accepted this revision.Oct 12 2014, 5:07 PM
bz edited edge metadata.

Looks good to me; m_getjcl() has no man page it seems ;-(

This revision is now accepted and ready to land.Oct 12 2014, 5:07 PM
glebius accepted this revision.Oct 12 2014, 9:48 PM
glebius edited edge metadata.
rwatson closed this revision.Oct 13 2014, 6:51 AM
rwatson updated this revision to Diff 1970.

Closed by commit rS273028 (authored by @rwatson).

rpaulo added a subscriber: rpaulo.Nov 1 2014, 7:29 PM

It might be better to put these reviews under 'network'.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
msk/
4 lines
nfe/
4 lines
sk/
4 lines

Diff 1970

View Options

head/sys/dev/msk/if_msk.c

Loading...
View Options

head/sys/dev/nfe/if_nfe.c

Loading...
View Options

head/sys/dev/sk/if_sk.c

Loading...