Differential D7552

[mips/broadcom] Replace static frequency table with generic PMU clock handling.
ClosedPublic
Actions

Authored by landonf on Aug 18 2016, 4:54 AM.

Tags

None

Referenced Files

	F135955103: D7552.id19431.diff
	Fri, Nov 14, 1:07 PM

	Unknown Object (File)
	Thu, Nov 13, 10:17 PM

	Unknown Object (File)
	Tue, Nov 4, 11:57 PM

	Unknown Object (File)
	Thu, Oct 30, 7:23 PM

	Unknown Object (File)
	Thu, Oct 30, 2:35 PM

	Unknown Object (File)
	Thu, Oct 30, 2:35 PM

	Unknown Object (File)
	Thu, Oct 30, 2:35 PM

	Unknown Object (File)
	Thu, Oct 30, 10:10 AM

Subscribers

Details

Reviewers

mizhka
adrian

Commits

rS304871: [mips/broadcom]: Replace static frequency table with generic PMU clock

Summary

Changes:

Extended PWRCTL/PMU APIs to support querying clock frequency during very early boot, prior to bus attach.
Implement generic PMU-based calculation of UART rclk values.
Replaced use of static frequency tables (bcm_socinfo) with runtime-determined values.

Depends on D7492

Test Plan

For RT-N16, RT-N53, and WGT634U:

Verified computed clock values against those specified in static table.
Verified that I did not, in fact, break the serial console.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4853
Build 4916: arc lint + arc unit

Event Timeline

landonf updated this revision to Diff 19431.Aug 18 2016, 4:54 AM

landonf retitled this revision from to [mips/broadcom] Replace static frequency table with generic PMU clock handling..

landonf updated this object.

landonf edited the test plan for this revision. (Show Details)

landonf added reviewers: adrian, mizhka.

landonf added a parent revision: D7492: [bhnd] Initial power/clock management support..

Herald added a subscriber: imp. · View Herald TranscriptAug 18 2016, 4:54 AM

Avoid using implicit global variables in BCM register macros. In theory, all the bcm_platform APIs should be usable with an arbitrary bcm_platform instance.
PMU watchdog writes were always sent to ChipCommon, even if a PMU core was found. Since none of our currently supported devices use a distinct PMU core (and map the register block to ChipCommon), this worked fine.
Due to a typo, the UART clock divisor register offset (instead of value) was improperly masked.

landonf added a child revision: D7570: Include the chip model (e.g. BCM4xxx) in bhnd(4) bus's device descriptions..Aug 18 2016, 7:07 PM

adrian accepted this revision.Aug 18 2016, 11:53 PM

adrian edited edge metadata.

This revision is now accepted and ready to land.Aug 18 2016, 11:53 PM

Closed by commit rS304871: [mips/broadcom]: Replace static frequency table with generic PMU clock (authored by landonf). · Explain WhyAug 27 2016, 12:06 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

dev/

bhnd/

cores/

chipc/

20 lines

pwrctl/

bhnd_pwrctl_subr.c

149 lines

bhnd_pwrctlvar.h

15 lines

pmu/

48 lines

bhnd_pmu_private.h

33 lines

bhnd_pmu_subr.c

356 lines

82 lines

mips/

broadcom/

54 lines

35 lines

298 lines

2 lines

uart_bus_chipc.c

10 lines

uart_cpu_chipc.c

10 lines

Diff 19462

sys/dev/bhnd/cores/chipc/chipcreg.h

Loading...

sys/dev/bhnd/cores/chipc/pwrctl/bhnd_pwrctl_subr.c

Loading...

sys/dev/bhnd/cores/chipc/pwrctl/bhnd_pwrctlvar.h

Loading...

sys/dev/bhnd/cores/pmu/bhnd_pmu.c

Loading...

sys/dev/bhnd/cores/pmu/bhnd_pmu_private.h

Loading...

sys/dev/bhnd/cores/pmu/bhnd_pmu_subr.c

Loading...

sys/dev/bhnd/cores/pmu/bhnd_pmuvar.h

Loading...

sys/mips/broadcom/bcm_machdep.h

Loading...

sys/mips/broadcom/bcm_machdep.c

Loading...

sys/mips/broadcom/bcm_pmu.c

Loading...

sys/mips/broadcom/bcm_socinfo.h

Loading...

sys/mips/broadcom/bcm_socinfo.c

Loading...

sys/mips/broadcom/files.broadcom

Loading...

sys/mips/broadcom/uart_bus_chipc.c

Loading...

sys/mips/broadcom/uart_cpu_chipc.c

Loading...