Page MenuHomeFreeBSD
Differential D7570

Include the chip model (e.g. BCM4xxx) in bhnd(4) bus's device descriptions.
ClosedPublic
Actions

Authored by landonf on Aug 18 2016, 7:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 3, 9:19 PM
Unknown Object (File)
Sat, Nov 30, 6:28 PM
Unknown Object (File)
Mon, Nov 25, 6:31 PM
Unknown Object (File)
Thu, Nov 21, 7:52 AM
Unknown Object (File)
Nov 13 2024, 6:31 AM
Unknown Object (File)
Oct 29 2024, 5:42 AM
Unknown Object (File)
Oct 28 2024, 5:10 AM
Unknown Object (File)
Oct 5 2024, 1:32 PM
View All 86 Files
Subscribers
imp
mizhka

Details

Reviewers
mizhka
adrian
Commits
rS304872: bhnd(4): Include the chip model (e.g. BCM4xxx) in bhnd(4) bus's device
Summary

Pretty much what it says on the tin. Examples:

bhnd0: <BCM4312 SIBA bus> on bhndb0
bhnd0: <BCM43225 BCMA bus> on bhndb0

bhnd0: <BCM4716 BCMA bus> at mem 0x18000000-0x180fffff on nexus0
bhnd0: <BCM5365 SIBA bus> at mem 0x18000000-0x180fffff on nexus0

Depends on D7552

Test Plan
  • Does it blend?

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

landonf updated this revision to Diff 19466.Aug 18 2016, 7:07 PM
landonf retitled this revision from to Include the chip model (e.g. BCM4xxx) in bhnd(4) bus's device descriptions..
landonf updated this object.
landonf edited the test plan for this revision. (Show Details)
landonf added a reviewer: adrian.
landonf added a parent revision: D7552: [mips/broadcom] Replace static frequency table with generic PMU clock handling..
Herald added a subscriber: imp. · View Herald TranscriptAug 18 2016, 7:07 PM
mizhka requested changes to this revision.Aug 22 2016, 10:03 AM
mizhka added a reviewer: mizhka.
mizhka added a subscriber: mizhka.
mizhka added inline comments.
sys/dev/bhnd/bhnd_subr.c
308 ↗(On Diff #19466)

Let's use "< 40000" instead of 0x9FFF (40959). It allows to exclude all 4xxxx and 5xxxx chip IDs.

This revision now requires changes to proceed.Aug 22 2016, 10:03 AM
landonf updated this revision to Diff 19550.Aug 22 2016, 5:38 PM
landonf edited edge metadata.
  • Cap the hex formatted range at 40000 (encompassing 0x4000-0x9C3F).
landonf marked an inline comment as done.Aug 22 2016, 5:39 PM
mizhka accepted this revision.Aug 22 2016, 6:00 PM
mizhka edited edge metadata.
This revision is now accepted and ready to land.Aug 22 2016, 6:00 PM
adrian accepted this revision.Aug 26 2016, 3:50 AM
adrian edited edge metadata.
Closed by commit rS304872: bhnd(4): Include the chip model (e.g. BCM4xxx) in bhnd(4) bus's device (authored by landonf). · Explain WhyAug 27 2016, 12:08 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
bhnd/
bcma/
13 lines
3 lines
8 lines
70 lines
siba/
13 lines
3 lines

Diff 19743

View Options

head/sys/dev/bhnd/bcma/bcma_bhndb.c

Loading...
View Options

head/sys/dev/bhnd/bcma/bcma_nexus.c

Loading...
View Options

head/sys/dev/bhnd/bhnd.h

Loading...
View Options

head/sys/dev/bhnd/bhnd_subr.c

Loading...
View Options

head/sys/dev/bhnd/siba/siba_bhndb.c

Loading...
View Options

head/sys/dev/bhnd/siba/siba_nexus.c

Loading...