hyperv/util: Don't reference hn_softc in KVP
ClosedPublic
Actions

Authored by sepherosa_gmail.com on Aug 16 2016, 3:46 AM.

Details

Reviewers

howard0su_gmail.com
honzhan_microsoft.com
decui_microsoft.com
delphij
royger

Commits

rS304270: hyperv/util: Don't reference hn_softc in KVP

Summary

hn_softc is private data struct.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

sepherosa_gmail.com updated this revision to Diff 19316.Aug 16 2016, 3:46 AM

sepherosa_gmail.com retitled this revision from to hyperv/util: Don't reference hn_softc in KVP.

sepherosa_gmail.com updated this object.

sepherosa_gmail.com edited the test plan for this revision. (Show Details)

sepherosa_gmail.com added reviewers: delphij, royger, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com.

honzhan_microsoft.com accepted this revision.Aug 16 2016, 7:18 AM

honzhan_microsoft.com edited edge metadata.

This revision is now accepted and ready to land.Aug 16 2016, 7:18 AM

Closed by commit rS304270: hyperv/util: Don't reference hn_softc in KVP (authored by sephe). · Explain WhyAug 17 2016, 8:26 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

hyperv/

utilities/

hv_kvp.c

10 lines

Diff 19386

View Options

head/sys/dev/hyperv/utilities/hv_kvp.c

Show First 20 Lines • Show All 78 Lines • ▼ Show 20 Lines
#include <vm/vm_pager.h>		#include <vm/vm_pager.h>

#include <machine/cpu.h>		#include <machine/cpu.h>
#include <machine/intr.h>		#include <machine/intr.h>
#include <machine/kdb.h>		#include <machine/kdb.h>
#include <machine/machdep.h>		#include <machine/machdep.h>
#include <machine/metadata.h>		#include <machine/metadata.h>
#include <machine/pcb.h>		#include <machine/pcb.h>
		#include <machine/pte.h>
#include <machine/reg.h>		#include <machine/reg.h>
#include <machine/riscvreg.h>		#include <machine/riscvreg.h>
#include <machine/sbi.h>		#include <machine/sbi.h>
#include <machine/trap.h>		#include <machine/trap.h>
#include <machine/vmparam.h>		#include <machine/vmparam.h>

#ifdef FPE		#ifdef FPE
#include <machine/fpe.h>		#include <machine/fpe.h>
▲ Show 20 Lines • Show All 727 Lines • ▼ Show 20 Lines	initriscv(struct riscv_bootparams *rvbp)
boothowto = RB_VERBOSE \| RB_SINGLE;		boothowto = RB_VERBOSE \| RB_SINGLE;
boothowto = RB_VERBOSE;		boothowto = RB_VERBOSE;

kern_envp = NULL;		kern_envp = NULL;

#ifdef FDT		#ifdef FDT
try_load_dtb(kmdp);		try_load_dtb(kmdp);

		/*
		* Exclude reserved memory specified by the device tree. Typically,
		* this contains an entry for memory used by the runtime SBI firmware.
		*/
		if (fdt_get_reserved_mem(mem_regions, &mem_regions_sz) == 0) {
		physmem_exclude_regions(mem_regions, mem_regions_sz,
		EXFLAG_NODUMP \| EXFLAG_NOALLOC);
		}

/* Grab physical memory regions information from device tree. */		/* Grab physical memory regions information from device tree. */
if (fdt_get_mem_regions(mem_regions, &mem_regions_sz, NULL) != 0)		if (fdt_get_mem_regions(mem_regions, &mem_regions_sz, NULL) != 0) {
panic("Cannot get physical memory regions");		panic("Cannot get physical memory regions");
		}
physmem_hardware_regions(mem_regions, mem_regions_sz);		physmem_hardware_regions(mem_regions, mem_regions_sz);
#endif		#endif

/* Do basic tuning, hz etc */		/* Do basic tuning, hz etc */
init_param1();		init_param1();

cache_setup();		cache_setup();
		markjUnsubmitted Not Done Inline Actions I wouldn't omit braces here, since the if and else bodies span multiple lines. markj: I wouldn't omit braces here, since the if and else bodies span multiple lines.

/* Bootstrap enough of pmap to enter the kernel proper */		/* Bootstrap enough of pmap to enter the kernel proper */
kernlen = (lastaddr - KERNBASE);		kernlen = (lastaddr - KERNBASE);
pmap_bootstrap(rvbp->kern_l1pt, mem_regions[0].mr_start, kernlen);		pmap_bootstrap(rvbp->kern_l1pt, mem_regions[0].mr_start, kernlen);

physmem_init_kernel_globals();		physmem_init_kernel_globals();

		#ifdef FDT
		/*
		* XXX: Exclude the lowest 2MB of physical memory, if it hasn't been
		* already, as this area is assumed to contain the SBI firmware. This
		* is a little fragile, but it is consistent with the platforms we
		* support so far.
		*
		* TODO: remove this when the all regular booting methods properly
		* report their reserved memory in the device tree.
		*/
		if (mem_regions[0].mr_start == physmap[0]) {
		physmem_exclude_region(mem_regions[0].mr_start, L2_SIZE,
		EXFLAG_NODUMP \| EXFLAG_NOALLOC);
		}
		#endif

/* Establish static device mappings */		/* Establish static device mappings */
devmap_bootstrap(0, NULL);		devmap_bootstrap(0, NULL);

cninit();		cninit();

init_proc0(rvbp->kern_stack);		init_proc0(rvbp->kern_stack);

Show All 23 Lines

hyperv/util: Don't reference hn_softc in KVPClosedPublicActions