[mips/broadcom] Implement early boot hardware probing and generic platform_reset() support.
ClosedPublic
Actions

Authored by landonf on Aug 16 2016, 10:13 PM.

Details

Reviewers

mizhka
adrian

Commits

rS304859: [mips/broadcom] Generic platform_reset() support.

Summary

This adds support for performing platform_reset() on all supported
devices, using early boot enumeration of chipc capabilities and
available cores.

Changes:

Extended platform_reset() to support PMU, PMU+AOB, and non-PMU devices.
Added a bcm_platform structure for tracking chipc/pmu/cfe platform data.
Extended the BCMA EROM API to support early boot lookup of core info (including port/region mappings).
Added Broadcom-specific MIPS CP0 register definitions used by BCM4785-specific reset handling.

Depends on D7498

Test Plan

Verified no regressions in reset handling on Asus RT-N16 and Netgear WGT634U.
Confirmed no regressions in bcma(4) bus enumeration on all supported SoC and WiFi chipsets.
Verified that reset now works correctly on Asus RT-N53, resolving the issue described in D6988.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4826
Build 4885: arc lint + arc unit

Event Timeline

landonf updated this revision to Diff 19371.Aug 16 2016, 10:13 PM

landonf retitled this revision from to [mips/broadcom] Implement early boot hardware probing and generic platform_reset() support..

landonf updated this object.

landonf edited the test plan for this revision. (Show Details)

landonf added reviewers: adrian, mizhka.

landonf added a parent revision: D7498: [mips/broadcom] Add CFE-based EARLY_PRINTF support..

Herald added a subscriber: imp. · View Herald TranscriptAug 16 2016, 10:13 PM

Rebase against master.

landonf mentioned this in D7492: [bhnd] Initial power/clock management support..Aug 17 2016, 9:08 PM

landonf added a child revision: D7492: [bhnd] Initial power/clock management support..Aug 17 2016, 9:08 PM

mizhka accepted this revision.Aug 22 2016, 9:39 AM

mizhka edited edge metadata.

This revision is now accepted and ready to land.Aug 22 2016, 9:39 AM

adrian accepted this revision.Aug 26 2016, 3:50 AM

adrian edited edge metadata.

Closed by commit rS304859: [mips/broadcom] Generic platform_reset() support. (authored by landonf). · Explain WhyAug 26 2016, 8:16 PM

This revision was automatically updated to reflect the committed changes.

landonf mentioned this in D6988: [BHND] (fix-regression) reboot doesn't work: PMU watchdog must be triggered on shutdown.Sep 4 2016, 1:49 AM

If you both think it's fine, then I'm totally all for it going in :)

Revision Contents
Changeset List

Path

Size

sys/

dev/

bhnd/

bcma/

294 lines

21 lines

6 lines

39 lines

cores/

chipc/

chipcreg.h

10 lines

mips/

broadcom/

100 lines

93 lines

248 lines

190 lines

	bcm_siba.c
	bcm_socinfo.h

70 lines

13 lines

6 lines

2 lines

10 lines

Commit	Tree	Parents	Author	Summary	Date
48bf57be755a	2a6460a84aa0	86a2e10c688d f64c995d3d15	Landon Fuller	Merge branch 'user/landonf/bhnd/4001_mips_early_printf' into… (Show More…)	Aug 16 2016, 9:52 PM
86a2e10c688d	efc954ae96c4	dbd1f2c00e7e 1e7f2891b9cf	Landon Fuller	Merge branch 'master' into user/landonf/bhnd/4010_soc_erom	Aug 16 2016, 9:34 PM
dbd1f2c00e7e	c62bc6d8c333	b0488ff38061	Landon Fuller	Implement early boot probing of chipcommon capabilities and the PMU core, if… (Show More…)	Aug 16 2016, 9:08 PM
b0488ff38061	4791e8a30c82	1f89ce832962	Landon Fuller	Add API to support early boot lookup of per-core port/region mappings.	Aug 16 2016, 8:49 PM
1f89ce832962	b74189e984b2	519049ac021a	Landon Fuller	Drop unused legacy sentry5 clock code.	Aug 16 2016, 1:07 AM
519049ac021a	f6d9a09332a4	14d4e117fc3d	Landon Fuller	Add a new bcm_platform structure for tracking chipc/pmu/cfe platform data.	Aug 16 2016, 1:06 AM
14d4e117fc3d	88023528b18b	c8e6e3406d72	Landon Fuller	Implement non-CFE platform reset for PMU and non-PMU devices. (Show More…)	Aug 15 2016, 11:05 PM
c8e6e3406d72	2362cd8b2995	bfc40f580116	Landon Fuller	Fix missing initialization of return value on success.	Aug 15 2016, 11:04 PM
bfc40f580116	4958b9dc54aa	1c8b45e46b4a	Landon Fuller	Add Broadcom-specific MIPS CP0 register definitions from CFE.	Aug 15 2016, 11:00 PM
1c8b45e46b4a	c129ae3cfcff	d84d576d2232	Landon Fuller	Stub out fetching of the ChipCommon capability flags.	Aug 15 2016, 6:42 PM
d84d576d2232	e1e0f05f27e1	01687f536262	Landon Fuller	Fix bus-level chip type handling broken in last commit.	Aug 15 2016, 6:41 PM
01687f536262	a8ccb6b0e717	fe847efb5c69	Landon Fuller	Add common bcm_soc_chipid() and CHIPC register access functions.	Aug 15 2016, 6:30 PM
fe847efb5c69	6d25f34728e8	78cc5e7ab15f	Landon Fuller	Use the actual ChipCommon base address when populating a siba(4) bhnd_chipid… (Show More…)	Aug 15 2016, 12:22 AM
78cc5e7ab15f	df4be97e6255	e1ef2e32f7d7	Landon Fuller	Use the device hints to locate the ChipC/EXTIF based address.	Aug 15 2016, 12:20 AM
e1ef2e32f7d7	01c1a70629c9	18a05190b19a 611a4f76e1e0	Landon Fuller	Merge branch 'user/landonf/bhnd/4001_mips_early_printf' into… (Show More…)	Aug 14 2016, 11:28 PM
18a05190b19a	9f21466b7803	bda1739fd31e	Landon Fuller	Add support for initializing the EROM parser with a bus space tag/handle, for… (Show More…)	Aug 14 2016, 8:18 PM