Adjust t4_port_init() to work with VF devices.
ClosedPublic
Actions

Authored by jhb on Aug 15 2016, 8:05 PM.

Details

Reviewers

Commits

rS304482: Adjust t4_port_init() to work with VF devices.

Summary

Adjust t4_port_init() to work with VF devices.

Specifically, the FW_PORT_CMD may or may not work for a VF (the PF
driver can choose whether or not to permit access to this command),
so don't attempt to fetch port information on a VF if permission is
denied by the PF.

Test Plan

tested with both VF and PF devices in the VF branch

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4805
Build 4861: arc lint + arc unit

Event Timeline

jhb updated this revision to Diff 19306.Aug 15 2016, 8:05 PM

jhb retitled this revision from to Adjust t4_port_init() to work with VF devices..

jhb updated this object.

jhb edited the test plan for this revision. (Show Details)

jhb added a reviewer: np.

Herald added a subscriber: imp. · View Herald TranscriptAug 15 2016, 8:05 PM

np added inline comments.Aug 15 2016, 9:31 PM

sys/dev/cxgbe/common/t4_hw.c
7945	p->tx_chan is being used before it has been initialized.

jhb added inline comments.Aug 16 2016, 10:16 PM

sys/dev/cxgbe/common/t4_hw.c
7945	Oops, I'll revert that back to 'j'. I had originally moved this below t4_alloc_vi() but had to move it back and this is leftover from that.

pi->tx_chan/j was the only comment I had, rest looks good.

This revision is now accepted and ready to land.Aug 17 2016, 12:06 AM

Closed by commit rS304482: Adjust t4_port_init() to work with VF devices. (authored by jhb). · Explain WhyAug 19 2016, 5:53 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

dev/

cxgbe/

common/

t4_hw.c

37 lines

Diff 19306

View Options

sys/dev/cxgbe/common/t4_hw.c

Adjust t4_port_init() to work with VF devices.ClosedPublicActions