pmc: Fix a few bugs and usability improvements to the pmc command
Needs ReviewPublic
Actions

Authored by ali_mashtizadeh.com on Wed, Nov 11, 9:56 PM.

Project Tags

Referenced Files

	F177480392: D61447.1794528646.diff
	Thu, Nov 12, 12:10 AM

	F177480165: D61447.1794527561.diff
	Wed, Nov 11, 11:52 PM

	F177480133: D61447.1794527375.diff
	Wed, Nov 11, 11:49 PM

Subscribers

adrian

imp

Details

Reviewers

adrian
mhorne
afscoelho_gmail.com

Group Reviewers

pmc

Summary

This change fixes a few important bugs that have been in pmcstat
including propaging Drew's fix for the address relocation of user
programs, stop repeated attempts to load symbols for programs with zero
symbols and improve the command line switches.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 79008
Build 75891: arc lint + arc unit

Event Timeline

ali_mashtizadeh.com created this revision.Wed, Nov 11, 9:56 PM

Herald added a subscriber: imp. · View Herald TranscriptWed, Nov 11, 9:56 PM

ali_mashtizadeh.com requested review of this revision.Wed, Nov 11, 9:56 PM

Harbormaster completed remote builds in B79008: Diff 192282.Wed, Nov 11, 9:56 PM

ali_mashtizadeh.com added a child revision: D58923: pmc: Display system level breakdown of performance data.Wed, Nov 11, 9:56 PM

adrian added a project: pmc.Wed, Nov 11, 11:12 PM

adrian subscribed.Wed, Nov 11, 11:15 PM

adrian added inline comments.

usr.sbin/pmc/view.cc
750	I know this is 4096 bytes, but surely we have a better way of setting this up?
797	typo

ali_mashtizadeh.com edited the test plan for this revision. (Show Details)Wed, Nov 11, 11:37 PM

ali_mashtizadeh.com added reviewers: adrian, mhorne, pmc, afscoelho_gmail.com.

ali_mashtizadeh.com added inline comments.Wed, Nov 11, 11:39 PM

usr.sbin/pmc/view.cc
750	Ah yea I'll remove that, it was until Drew's patch landed up stream I needed this. A similar logic sets the default page shift using the macro in libpmc so I can always count on it.