Differential D7454

Add a stage-qa check to check for the existence of SONAME in .so's.
ClosedPublic
Actions

Authored by mat on Aug 9 2016, 10:23 PM.

Details

Reviewers

None

Group Reviewers

portmgr

Commits

rP421068: Add a stage-qa check to check for the existence of SONAME in .so's.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 4744
Build 4798: arc lint + arc unit

Event Timeline

mat updated this revision to Diff 19168.Aug 9 2016, 10:23 PM

mat retitled this revision from to Add a stage-qa check to check for the existence of SONAME in .so's..

mat updated this object.

mat edited the test plan for this revision. (Show Details)

Herald added a reviewer: portmgr. · View Herald TranscriptAug 9 2016, 10:23 PM

This probably needs special handling for ports that bundle libraries purposely with no SONAME. I think the wine and openoffice ports do this.

On the other hand, is this really a pkg bug?

Incorporate the soname checks in proxydeps.

Herald edited edge metadata. · View Herald TranscriptAug 9 2016, 10:55 PM

Make it an error, it is BAD.

Herald edited edge metadata. · View Herald TranscriptAug 9 2016, 10:56 PM

The fact that a .so doesn't have a SONAME is only a warning, because, hey, it may not be important.

On the other hand the fact that something uses a .so from another port without a SONAME is bad as pkg won't keep track of it.

I'm sure @bapt will say that every .so needs to have a SONAME :-)

Only the libraries in the form libbla.so.X needs a soname, otherwise when linked to a binary, the binary will be linked to libbla.so and not the libbla.so.X it should be looking for.
The check should not happen for ports that have the BUNDLE_LIBS=yes knob

Closed by commit rP421068: Add a stage-qa check to check for the existence of SONAME in .so's. (authored by mat). · Explain WhyAug 29 2016, 3:24 PM

This revision was automatically updated to reflect the committed changes.