Tags

None

Referenced Files

	F176530588: D60816.id190132.diff
	Mon, Oct 19, 2:41 PM

	F176463655: D60816.id190203.diff
	Mon, Oct 19, 1:38 AM

	F176463492: D60816.id190203.diff
	Mon, Oct 19, 1:36 AM

	F176462787: D60816.id190193.diff
	Mon, Oct 19, 1:27 AM

	F176462461: D60816.id190196.diff
	Mon, Oct 19, 1:24 AM

	F176462445: D60816.id190196.diff
	Mon, Oct 19, 1:24 AM

	F176445097: D60816.id190132.diff
	Sun, Oct 18, 10:44 PM

	F176441556: D60816.id190203.diff
	Sun, Oct 18, 10:15 PM

View All 27 Files

Subscribers

None

Details

Reviewers

fuz
jrm

Commits

R11:5b088a83ef46: x11/bhotkeys-lid-state: Update to 1.3.2

Summary

Provide OSD feedback to user when lid-switchd service is not running
Simplify lid-wake-toggle script
Adjust whitespace in rc.d/lid-switchd[.in]
Create lid-switchd service pidfile 0644
Provide OSD feedback to user when lid-switchd socket is unwritable

Changelog: https://github.com/FrauBSD/bhotkeys-lid-state/blob/1.3.2/CHANGELOG.md

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 78336
Build 75219: arc lint + arc unit

Event Timeline

dteske requested review of this revision.Sat, Oct 17, 5:49 PM

dteske created this revision.

Harbormaster completed remote builds in B78304: Diff 190130.Sat, Oct 17, 5:49 PM

makesum to pull in recent fix and tag move

Harbormaster completed remote builds in B78305: Diff 190132.Sat, Oct 17, 6:12 PM

Slurp in a couple more changes

Harbormaster completed remote builds in B78335: Diff 190193.Sun, Oct 18, 11:48 AM

One last usability improvement. Show a bosd error if the lid-switchd
socket is unwritable, pointing the user at lid-switchd(8) man-page,
informing them that they have to pw groupmod lid_switchd -m username
and log-out then back in to join the group that is able to talk to
the lid-switchd daemon through its socket owned by root:lid_switchd

Harbormaster completed remote builds in B78336: Diff 190196.Sun, Oct 18, 12:06 PM

dteske edited the summary of this revision. (Show Details)Sun, Oct 18, 12:23 PM

LGTM, no issues in the Makefile.

This revision is now accepted and ready to land.Sun, Oct 18, 12:32 PM

Closed by commit R11:5b088a83ef46: x11/bhotkeys-lid-state: Update to 1.3.2 (authored by dteske). · Explain WhySun, Oct 18, 3:32 PM

This revision was automatically updated to reflect the committed changes.

dteske added a commit: R11:5b088a83ef46: x11/bhotkeys-lid-state: Update to 1.3.2.