[PATCH 2/5] pwm: polarity, enable-gpios and level bookkeeping for Allwinner backlights
Needs RevisionPublic
Actions

Authored by vice-shore-grid_duck.com on Fri, Oct 16, 8:44 PM.

Details

Reviewers

andrew
manu

Group Reviewers

arm64

Summary

Everything needed for a pwm-backlight node such as the PineTab's
(inverted PWM on PD22, enable-gpios, brightness-levels) to drive the
panel backlight on the A64.

Note that the changes in ad64_padconf.c have already been reported in the following bugzilla issue: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=299368 I can close it, if this is picked up first.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

vice-shore-grid_duck.com created this revision.Fri, Oct 16, 8:44 PM

Herald added a reviewer: andrew. · View Herald TranscriptFri, Oct 16, 8:44 PM

Herald added a reviewer: manu. · View Herald Transcript

Herald added subscribers: loos, imp. · View Herald Transcript

vice-shore-grid_duck.com requested review of this revision.Fri, Oct 16, 8:44 PM

Please upload your diff with full context next time.

sys/arm/allwinner/aw_gpio.c
1061	aw_gpio code should be in another review.
sys/dev/pwm/controller/allwinner/aw_pwm.c
271	Why this change ?
314	Why those changes ?
419	get_flags/set_flags should be a separated review.
sys/dev/pwm/pwm_backlight.c
169	flags is never set so not sure I understand why you want to achieve here.