math/R-cran-metafor: New port: Meta-analysis package for R
ClosedPublic
Actions

Authored by longros on Wed, Oct 14, 6:44 AM.

Details

Reviewers

jrm
yuri

Commits

R11:850ef4f5a5e2: math/R-cran-metafor: New port: Meta-analysis package for R

Summary

Meta-analysis package for R. metadat and pbapply are already ported.

Test Plan

poudriere testport passes in 144amd64, 145amd64 and 151

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 78242
Build 75125: arc lint + arc unit

Event Timeline

longros requested review of this revision.Wed, Oct 14, 6:44 AM

longros created this revision.

Harbormaster completed remote builds in B78208: Diff 189859.Wed, Oct 14, 6:44 AM

longros edited the summary of this revision. (Show Details)Wed, Oct 14, 6:45 AM

longros edited the test plan for this revision. (Show Details)

distilator shows that the WWW URL redirects. The redirect target should be in the WWW field.
You should always run distilator for new ports and port updates to check whether important URLs like WWW and MASTER_SITES redirect.

make sure that the URL redirects with distilator

Harbormaster completed remote builds in B78242: Diff 189981.Thu, Oct 15, 6:07 PM

In D60718#1392564, @yuri wrote:

distilator shows that the WWW URL redirects. The redirect target should be in the WWW field.
You should always run distilator for new ports and port updates to check whether important URLs like WWW and MASTER_SITES redirect.

Done

Optional: It looks like this package has tests. Could they be hooked into the port?

math/R-cran-metafor/Makefile
22	`NO_ARCH=yes` is redundant with `USE=cran` without `compiles`. https://github.com/freebsd/freebsd-ports/blob/main/Mk/Uses/cran.mk#L68-L75

remove NO_ARCH= yes

Harbormaster completed remote builds in B78256: Diff 190019.Fri, Oct 16, 9:05 AM

longros marked an inline comment as done.Fri, Oct 16, 9:06 AM

longros mentioned this in D60763: devel/R-cran-pbapply, math/R-cran-metadat: Remove redundant NO_ARCH.Fri, Oct 16, 9:55 AM

jrm accepted this revision.Fri, Oct 16, 1:43 PM

This revision is now accepted and ready to land.Fri, Oct 16, 1:43 PM

Closed by commit R11:850ef4f5a5e2: math/R-cran-metafor: New port: Meta-analysis package for R (authored by longros). · Explain WhyFri, Oct 16, 3:07 PM

This revision was automatically updated to reflect the committed changes.

longros added a commit: R11:850ef4f5a5e2: math/R-cran-metafor: New port: Meta-analysis package for R.

longros mentioned this in R11:baebf92d1acf: devel/R-cran-pbapply, math/R-cran-metadat: Remove redundant NO_ARCH.

dteske added a subscriber: dteske.Sat, Oct 17, 8:37 PM

dteske added inline comments.

math/R-cran-metafor/Makefile
9	This is the old deprecated URL format. See https://reviews.freebsd.org/D59714 No need to update. I'm rolling another differential to update this and some other stragglers that I missed in D59714