Page MenuHomeFreeBSD
Differential D60590

periodic: clean up security/100.chksetuid
Needs RevisionPublic
Actions

Authored by ngie on Sat, Oct 10, 6:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 15, 7:22 AM
Unknown Object (File)
Thu, Oct 15, 5:24 AM
Unknown Object (File)
Tue, Oct 13, 3:59 AM
Unknown Object (File)
Mon, Oct 12, 6:56 AM
Unknown Object (File)
Sun, Oct 11, 5:01 PM
Unknown Object (File)
Sun, Oct 11, 4:55 PM
Unknown Object (File)
Sun, Oct 11, 6:00 AM
Unknown Object (File)
Sat, Oct 10, 11:01 PM
View All 10 Files
Subscribers
emaste
imp
jilles

Details

Reviewers
jilles
Summary
  • Use the abbreviated licensing tort with the SPDX ID instead of the longer form version.
  • Make several minor changes to appease shellcheck.
  • Normalize on hard tabs in this file.

No net functional change is intended.

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 77969
Build 74852: arc lint + arc unit

Event Timeline

ngie created this revision.Sat, Oct 10, 6:17 PM
Herald added a subscriber: imp. · View Herald TranscriptSat, Oct 10, 6:17 PM
ngie requested review of this revision.Sat, Oct 10, 6:17 PM
Harbormaster completed remote builds in B77969: Diff 189378.Sat, Oct 10, 6:17 PM
ngie added a reviewer: jilles.Sat, Oct 10, 6:18 PM
ngie added subscribers: emaste, jilles.

@emaste : I added you to the subscriber list so you can maybe give a thumbs up on the SPDX ID changes.

jilles requested changes to this revision.Sun, Oct 11, 4:52 PM
jilles added inline comments.
usr.sbin/periodic/etc/security/100.chksetuid
30

Word splitting is intended here (in case there is more than one mount point with suid enabled).

This revision now requires changes to proceed.Sun, Oct 11, 4:52 PM
ngie added inline comments.Sun, Oct 11, 7:49 PM
usr.sbin/periodic/etc/security/100.chksetuid
30

Word splitting is intended here (in case there is more than one mount point with suid enabled).

You're right -- I'm kind of tempted to use xargs -n 1 here to avoid E2BIG issues with a large number of matched mountpoints. Thoughts?

ngie added inline comments.Sun, Oct 11, 7:51 PM
usr.sbin/periodic/etc/security/100.chksetuid
30

Word splitting is intended here (in case there is more than one mount point with suid enabled).

You're right -- I'm kind of tempted to use xargs -n 1 here to avoid E2BIG issues with a large number of matched mountpoints. Thoughts?

Note to self/others: the above suggestion would require adjusting how find is run since it sorts the results with -s and separate invocations would "break" the fact that find is doing that sorting.

ngie marked an inline comment as done.Sun, Oct 11, 10:01 PM
ngie added inline comments.
usr.sbin/periodic/etc/security/100.chksetuid
30

Word splitting is intended here (in case there is more than one mount point with suid enabled).

Restoring the old behavior now is fine, BTW. Don't need to solve for the E2BIG scenario right now.

Revision Contents
Changeset List

PathSize
usr.sbin/
periodic/
etc/
security/
38 lines

Diff 189378

View Options

usr.sbin/periodic/etc/security/100.chksetuid

Loading...