Differential D60461

aq: support a legacy INTx interrupt
AcceptedPublic
Actions

Authored by nick_spun.io on Thu, Oct 8, 5:53 AM.

Tags

Referenced Files

	F176125983: D60461.id189027.diff
	Fri, Oct 16, 7:44 AM

	Unknown Object (File)
	Thu, Oct 15, 3:36 PM

	Unknown Object (File)
	Wed, Oct 14, 7:04 PM

	Unknown Object (File)
	Wed, Oct 14, 10:44 AM

	Unknown Object (File)
	Wed, Oct 14, 7:29 AM

	Unknown Object (File)
	Wed, Oct 14, 6:22 AM

	Unknown Object (File)
	Tue, Oct 13, 4:49 PM

	Unknown Object (File)
	Tue, Oct 13, 5:10 AM

View All 21 Files

Subscribers

Details

Reviewers

Summary

aq(4) attached only with MSI-X. Without an MSI controller iflib falls
back to INTx, and attach failed with EOPNOTSUPP.

Accept IFLIB_INTR_LEGACY, program the controller for INTx, and add a
legacy filter. INTx is level-triggered and nothing auto-masks, so the
filter masks the vector before acknowledging it; iflib unmasks it via
IFDI_INTR_ENABLE once the queues are drained. All causes already map
to vector 0 in this mode. MSI stays unsupported: iflib never selects
it here, since these controllers advertise 32 messages.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77840
Build 74723: arc lint + arc unit

Event Timeline

nick_spun.io created this revision.Thu, Oct 8, 5:53 AM

Herald added a subscriber: imp. · View Herald TranscriptThu, Oct 8, 5:53 AM

nick_spun.io requested review of this revision.Thu, Oct 8, 5:53 AM

Harbormaster completed remote builds in B77840: Diff 189027.Thu, Oct 8, 5:53 AM

nick_spun.io added a child revision: D60462: aq: build the module on arm64.Thu, Oct 8, 5:54 AM

nick_spun.io added a reviewer: adrian.Fri, Oct 9, 7:43 PM

nick_spun.io added a project: drivers.

adrian accepted this revision.Fri, Oct 9, 8:00 PM

This revision is now accepted and ready to land.Fri, Oct 9, 8:00 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

aq/

1 line

2 lines

19 lines

6 lines

2 lines

Diff 189027

sys/dev/aq/aq_device.h

Loading...

sys/dev/aq/aq_hw.c

Loading...

sys/dev/aq/aq_irq.c

Loading...

sys/dev/aq/aq_main.c

Loading...

sys/dev/aq/aq_ring.c

Loading...