tests/libc: use an allowlist for sbrk in NetBSD-derived tests
ClosedPublic
Actions

Authored by zhaoxiaoqiang007_gmail.com on Mon, Oct 5, 4:21 AM.

Details

Reviewers

ngie
imp
kib
brooks

Commits

rGd45f069002f2: tests/libc: use an allowlist for sbrk in NetBSD-derived tests
rG36b849b5c764: tests/libc: use an allowlist for sbrk in NetBSD-derived tests

Summary

sbrk is obsolete and libc only provides it on amd64, arm, i386 and
powerpc. Replace the growing exclusion lists in t_dir.c and t_mlock.c
with a single positive HAVE_SBRK definition per file, so architectures
without sbrk need not be enumerated as they are added.

Signed-off-by: Xiaoqiang Zhao <zhaoxiaoqiang007@gmail.com>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77710
Build 74593: arc lint + arc unit

Event Timeline

zhaoxiaoqiang007_gmail.com created this revision.Mon, Oct 5, 4:21 AM

Herald added a reviewer: ngie. · View Herald TranscriptMon, Oct 5, 4:21 AM

Herald added a subscriber: imp. · View Herald Transcript

zhaoxiaoqiang007_gmail.com requested review of this revision.Mon, Oct 5, 4:21 AM

Harbormaster completed remote builds in B77710: Diff 188686.Mon, Oct 5, 4:21 AM

zhaoxiaoqiang007_gmail.com mentioned this in D59893: libc: add LoongArch support.Mon, Oct 5, 4:28 AM

zhaoxiaoqiang007_gmail.com added a reviewer: imp.Mon, Oct 5, 4:30 AM

zhaoxiaoqiang007_gmail.com added reviewers: kib, brooks.Mon, Oct 5, 4:32 AM

The aarch64 and riscv portions of the diff are unannotated FreeBSD modifications -- this is ok, but this really should be cleaned up in a future revision:

This revision is now accepted and ready to land.Sat, Oct 10, 5:38 PM

Closed by commit rG36b849b5c764: tests/libc: use an allowlist for sbrk in NetBSD-derived tests (authored by zhaoxiaoqiang007_gmail.com, committed by ngie). · Explain WhySat, Oct 10, 5:42 PM

This revision was automatically updated to reflect the committed changes.

ngie added a commit: rG36b849b5c764: tests/libc: use an allowlist for sbrk in NetBSD-derived tests.

ngie reopened this revision.Sat, Oct 10, 5:43 PM

ngie edited the summary of this revision. (Show Details)

This revision was not accepted when it landed; it landed in state Needs Review.Sat, Oct 10, 5:43 PM

Closed by commit rGd45f069002f2: tests/libc: use an allowlist for sbrk in NetBSD-derived tests (authored by zhaoxiaoqiang007_gmail.com, committed by ngie). · Explain Why

This revision was automatically updated to reflect the committed changes.

ngie added a reverting change: rGe8431fae655b: Revert "tests/libc: use an allowlist for sbrk in NetBSD-derived tests".

ngie added a commit: rGd45f069002f2: tests/libc: use an allowlist for sbrk in NetBSD-derived tests.