Page MenuHomeFreeBSD
Differential D60349

cam: Rename cam_iosched_bio_complete to cam_iosched_bio_update_stats
ClosedPublic
Actions

Authored by imp on Sun, Oct 4, 7:11 PM.
Tags
None
Referenced Files
F175418697: D60349.id188655.diff
Sat, Oct 10, 5:41 PM
F175364940: D60349.id188908.diff
Sat, Oct 10, 7:46 AM
F175350872: D60349.id188655.diff
Sat, Oct 10, 5:19 AM
F175310216: D60349.id188655.diff
Fri, Oct 9, 8:55 PM
Unknown Object (File)
Fri, Oct 9, 6:51 PM
Unknown Object (File)
Fri, Oct 9, 7:23 AM
Unknown Object (File)
Fri, Oct 9, 2:23 AM
Unknown Object (File)
Thu, Oct 8, 10:43 PM
View All 20 Files
Subscribers
dab

Details

Reviewers
chs
mav
ken
ali_mashtizadeh.com
Group Reviewers
cam
Commits
rG0040d1fb7a25: cam: Rename cam_iosched_bio_complete to cam_iosched_bio_update_stats
Summary

The function updates scheduler statistics but does not complete the
bio. Rename it to avoid implying ownership of bio completion.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 77703
Build 74586: arc lint + arc unit

Event Timeline

imp created this revision.Sun, Oct 4, 7:11 PM
Herald added a reviewer: cam. · View Herald TranscriptSun, Oct 4, 7:11 PM
Herald added a subscriber: dab. · View Herald Transcript
imp requested review of this revision.Sun, Oct 4, 7:11 PM
Harbormaster completed remote builds in B77703: Diff 188655.Sun, Oct 4, 7:11 PM
imp added a child revision: D60350: cam: Assert we have the periph lock when updating the iosched stats.Sun, Oct 4, 7:11 PM
ali_mashtizadeh.com accepted this revision.Tue, Oct 6, 6:25 PM

If you can add the assert and test if not we can do that in a separate diff.

sys/cam/cam_iosched.c
1781

Probably a good spot for a cam_periph_assert(... , MA_OWNED);

This revision is now accepted and ready to land.Tue, Oct 6, 6:25 PM
imp added inline comments.Tue, Oct 6, 7:15 PM
sys/cam/cam_iosched.c
1781

out of scope for this commit.
It's another patch on this stack though.

Closed by commit rG0040d1fb7a25: cam: Rename cam_iosched_bio_complete to cam_iosched_bio_update_stats (authored by imp). · Explain WhyTue, Oct 6, 10:59 PM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rG0040d1fb7a25: cam: Rename cam_iosched_bio_complete to cam_iosched_bio_update_stats.

Revision Contents
Changeset List

PathSize
sys/
cam/
ata/
2 lines
2 lines
2 lines
nvme/
6 lines
scsi/
2 lines

Diff 188655

View Options

sys/cam/ata/ata_da.c

Loading...
View Options

sys/cam/cam_iosched.h

Loading...
View Options

sys/cam/cam_iosched.c

Loading...
View Options

sys/cam/nvme/nvme_da.c

Loading...
View Options

sys/cam/scsi/scsi_da.c

Loading...