Differential D60273
jail: declare argument structure of jail(2) with const fields Authored by glebius on Sat, Oct 3, 4:39 AM. Tags None Referenced Files
Details The syscall doesn't modify this memory. With added 'const' one can use const struct in_addr laddr = { htonl(INADDR_LOOPBACK) }; .version = JAIL_API_VERSION, .path = "/", .hostname = "test", .ip4s = 1, .ip4 = &laddr, };
Diff Detail
Event TimelineComment Actions The const strings seem unlike to cause any trouble, but I wonder what code is out there along the lines of: struct jail j;
...
j.ip4 = calloc(nip4, sizeof(struct in_addr));
for (int i = 0; i < nip4; ++i)
inet_aton(ip4_arg[i], &j.ip4[i]);Comment Actions Yeah, that's true. I can also imagine a program that would modify a string as a member of struct jail before passing to jail(2). :( |