Differential D60149

mkimg: Add image_buffer_region
ClosedPublic
Actions

Authored by cperciva on Tue, Sep 29, 8:13 PM.

Tags

None

Referenced Files

	F174758919: D60149.id188131.diff
	Mon, Oct 5, 7:35 PM

	F174675998: D60149.id188131.diff
	Mon, Oct 5, 3:17 AM

	Unknown Object (File)
	Sun, Oct 4, 5:27 AM

	Unknown Object (File)
	Sun, Oct 4, 5:27 AM

	Unknown Object (File)
	Sun, Oct 4, 2:05 AM

	Unknown Object (File)
	Thu, Oct 1, 8:45 AM

	Unknown Object (File)
	Thu, Oct 1, 7:39 AM

	Unknown Object (File)
	Wed, Sep 30, 11:51 PM

View All 16 Files

Subscribers

Details

Reviewers

emaste
jrm

Commits

rG84a3e29c7203: mkimg: Add image_buffer_region

Summary

This is like image_copyout_region, but copies into a buffer rather than
writing out to a file; it will be used by future support for compressed
images (and potentially other circumstances where image data must be
manipulated before being written out to disk).

Sponsored by: Google LLC (GSoC 2025)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77499
Build 74382: arc lint + arc unit

Event Timeline

cperciva created this revision.Tue, Sep 29, 8:13 PM

Herald added a subscriber: imp. · View Herald TranscriptTue, Sep 29, 8:13 PM

cperciva requested review of this revision.Tue, Sep 29, 8:13 PM

Harbormaster completed remote builds in B77499: Diff 188131.Tue, Sep 29, 8:13 PM

cperciva added a parent revision: D60148: mkimg: Avoid leaking a page of mmap.Tue, Sep 29, 8:13 PM

cperciva added a child revision: D60150: mkimg: Make vmdk's desc_fmt slightly more generic.

This is an extract from Christos Komis's GSoC work, with a very minor change from me (the image_file_unmap API changed to fix a bug, see D60148).

I don't know if he has an account here.

jrm accepted this revision.Sat, Oct 3, 2:05 AM

This revision is now accepted and ready to land.Sat, Oct 3, 2:05 AM

Closed by commit rG84a3e29c7203: mkimg: Add image_buffer_region (authored by ChrisKom04 <komis.christo@gmail.com>, committed by cperciva). · Explain WhySat, Oct 3, 3:42 PM

This revision was automatically updated to reflect the committed changes.

cperciva added a commit: rG84a3e29c7203: mkimg: Add image_buffer_region.

Revision Contents
Changeset List

Path

Size

usr.bin/

mkimg/

1 line

68 lines

Diff 188131

usr.bin/mkimg/image.h

Loading...

usr.bin/mkimg/image.c

Loading...