mkimg: Avoid leaking a page of mmap
ClosedPublic
Actions

Authored by cperciva on Tue, Sep 29, 8:13 PM.

Details

Reviewers

emaste
sjg

Commits

rG434819b4fec5: mkimg: Avoid leaking a page of mmap

Summary

The image_file_map function adjusts the provided file offset to be
page-aligned, with a resulting increase in the size of the mapped
region; the increased size needs to be used when unmapping as well.

Reported by: Claude Opus 5.5
Fixes: baf4abfc39b2 ("Allow building mkimg as cross-tool")
Sponsored by: Amazon

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77498
Build 74381: arc lint + arc unit

Event Timeline

cperciva created this revision.Tue, Sep 29, 8:13 PM

Herald added a subscriber: imp. · View Herald TranscriptTue, Sep 29, 8:13 PM

cperciva requested review of this revision.Tue, Sep 29, 8:13 PM

Harbormaster completed remote builds in B77498: Diff 188130.Tue, Sep 29, 8:13 PM

cperciva added a parent revision: D60147: mkimg: Check for realloc failure.Tue, Sep 29, 8:13 PM

cperciva added a child revision: D60149: mkimg: Add image_buffer_region.

@sjg: Adding you since the commit I'm fixing is one of yours.

cperciva mentioned this in D60149: mkimg: Add image_buffer_region.Tue, Sep 29, 8:18 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sat, Oct 3, 3:42 PM

Closed by commit rG434819b4fec5: mkimg: Avoid leaking a page of mmap (authored by cperciva). · Explain Why

This revision was automatically updated to reflect the committed changes.

cperciva added a commit: rG434819b4fec5: mkimg: Avoid leaking a page of mmap.

Revision Contents
Changeset List

Path

Size

usr.bin/

mkimg/

image.c

9 lines

Diff 188130

View Options

mkimg: Avoid leaking a page of mmapClosedPublicActions