mkimg: Check for realloc failure
AcceptedPublic
Actions

Authored by cperciva on Tue, Sep 29, 8:13 PM.

Tags

None

Referenced Files

	F174169280: D60147.diff
	Thu, Oct 1, 2:49 AM

	F174151610: D60147.id188129.diff
	Wed, Sep 30, 11:15 PM

	F174150523: D60147.diff
	Wed, Sep 30, 11:06 PM

	F174129302: D60147.diff
	Wed, Sep 30, 7:42 PM

	F174103827: D60147.id188129.diff
	Wed, Sep 30, 3:58 PM

	Unknown Object (File)
	Wed, Sep 30, 4:46 AM

	Unknown Object (File)
	Wed, Sep 30, 3:23 AM

	Unknown Object (File)
	Tue, Sep 29, 10:47 PM

View All 9 Files

Subscribers

imp

Details

Reviewers

emaste

Summary

If realloc fails, clean up and return ENOMEM; don't just copy data
into NULL.

Reported by: Claude Opus 5.5
Sponsored by: Amazon

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77497
Build 74380: arc lint + arc unit

Event Timeline

cperciva created this revision.Tue, Sep 29, 8:13 PM

Herald added a subscriber: imp. · View Herald TranscriptTue, Sep 29, 8:13 PM

cperciva requested review of this revision.Tue, Sep 29, 8:13 PM

Harbormaster completed remote builds in B77497: Diff 188129.Tue, Sep 29, 8:13 PM

cperciva added a child revision: D60148: mkimg: Avoid leaking a page of mmap.Tue, Sep 29, 8:13 PM

emaste accepted this revision.Tue, Sep 29, 8:22 PM

This revision is now accepted and ready to land.Tue, Sep 29, 8:22 PM

Revision Contents
Changeset List

Path

Size

usr.bin/

mkimg/

vmdk.c

7 lines

Diff 188129

View Options

mkimg: Check for realloc failureAcceptedPublicActions