pmc(8): zero-initialize the event descriptor in stat mode
Needs ReviewPublic
Actions

Authored by afscoelho_gmail.com on Thu, Sep 3, 9:32 PM.

Details

Reviewers

ali_mashtizadeh.com
anascime_amd.com
ojanerif_amd.com
davichazbh_gmail.com

Group Reviewers

pmc

Summary

cmd_pmc_stat allocated the event descriptor with malloc and then set
only some of its fields, so the rest held whatever was on the heap.
Use calloc.

This is an independent fix. It does not depend on the PMU grouping
work, and can be committed on its own.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77479
Build 74362: arc lint + arc unit

Event Timeline

afscoelho_gmail.com created this revision.Thu, Sep 3, 9:32 PM

afscoelho_gmail.com held this revision as a draft.

Herald added a reviewer: ali_mashtizadeh.com. · View Herald TranscriptThu, Sep 3, 9:32 PM

Herald added a subscriber: imp. · View Herald Transcript

Harbormaster completed remote builds in B76458: Diff 185761.Thu, Sep 3, 9:32 PM

afscoelho_gmail.com added a parent revision: D59363: pmcstat(8): warn about unfittable grouped sample periods.Thu, Sep 3, 9:33 PM

afscoelho_gmail.com added a child revision: D59365: pmc, pmcstat: document PMU event grouping.

afscoelho_gmail.com published this revision for review.Tue, Sep 8, 12:36 PM

afscoelho_gmail.com added a reviewer: pmc.Tue, Sep 8, 3:34 PM

afscoelho_gmail.com edited the summary of this revision. (Show Details)

afscoelho_gmail.com added reviewers: anascime_amd.com, ojanerif_amd.com, davichazbh_gmail.com.Thu, Sep 10, 12:45 PM

Rebase onto main after D58256 landed.

Harbormaster completed remote builds in B77479: Diff 188103.Tue, Sep 29, 7:38 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

pmc/

cmd_pmc_stat.c

2 lines

Diff 188103

View Options

usr.sbin/pmc/cmd_pmc_stat.c

pmc(8): zero-initialize the event descriptor in stat modeNeeds ReviewPublicActions