Page MenuHomeFreeBSD
Differential D59989

x11/bosd: Add EXAMPLES option
ClosedPublic
Actions

Authored by dteske on Thu, Sep 24, 3:22 PM.
Tags
None
Referenced Files
F173612671: D59989.id187763.diff
Sun, Sep 27, 4:41 AM
F173603487: D59989.id187754.diff
Sun, Sep 27, 3:16 AM
F173572166: D59989.id187763.diff
Sat, Sep 26, 10:24 PM
Unknown Object (File)
Sat, Sep 26, 9:15 PM
Unknown Object (File)
Sat, Sep 26, 8:29 PM
Unknown Object (File)
Sat, Sep 26, 8:28 PM
Unknown Object (File)
Sat, Sep 26, 4:31 PM
Unknown Object (File)
Sat, Sep 26, 4:31 PM
View All 28 Files
Subscribers
None

Details

Reviewers
fuz
jrm
Commits
R11:f58e5c3241f4: x11/bosd: Add EXAMPLES option
Summary

Install the sample glyph scripts only when EXAMPLES is on. The
glyph PNGs stay in the icon directory.

Suggested by: fuz

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 77357
Build 74240: arc lint + arc unit

Event Timeline

dteske requested review of this revision.Thu, Sep 24, 3:22 PM
dteske created this revision.
Harbormaster completed remote builds in B77281: Diff 187610.Thu, Sep 24, 3:22 PM
dteske added a parent revision: D59715: x11/bosd: Update to 10.4.Thu, Sep 24, 3:22 PM
dteske mentioned this in D59715: x11/bosd: Update to 10.4.Thu, Sep 24, 3:23 PM
fuz accepted this revision.Fri, Sep 25, 9:55 AM

LGTM, and please bump PORTREVISION for this change.
Approved for commit.

This revision is now accepted and ready to land.Fri, Sep 25, 9:55 AM
dteske updated this revision to Diff 187679.Fri, Sep 25, 3:37 PM

Bump PORTREVISION as requested. Add TESTS_DESC so portlint is clean.

This revision now requires review to proceed.Fri, Sep 25, 3:37 PM
Harbormaster completed remote builds in B77330: Diff 187679.Fri, Sep 25, 3:37 PM
dteske updated this revision to Diff 187686.Fri, Sep 25, 3:45 PM

Bump PORTREVISION (fuz), add description for TESTS (portlint)

Harbormaster completed remote builds in B77331: Diff 187686.Fri, Sep 25, 3:45 PM
jrm added inline comments.Fri, Sep 25, 3:58 PM
x11/bosd/Makefile
15

Is the python run-time dependency only for the example scripts? If so, you could make it conditional.

EXAMPLES_USES=        python:build,run
EXAMPLES_USES_OFF=    python:build
dteske added inline comments.Fri, Sep 25, 4:27 PM
x11/bosd/Makefile
15

Good catch.

I initially meant to make share/examples/bosd/glyph.py u conditional but because it is in the examples dir, it got swept up in the other examples becoming conditional.

I may move glyph.py out of the examples dir or I might make the runtime dependency on Python conditional as you suggest. I need to think on which I will do

dteske updated this revision to Diff 187754.Sat, Sep 26, 4:08 PM

Rebase onto origin/main, remove python run dep

Harbormaster completed remote builds in B77357: Diff 187754.Sat, Sep 26, 4:08 PM
dteske marked an inline comment as done.Sat, Sep 26, 4:09 PM
fuz accepted this revision.Sat, Sep 26, 5:16 PM

Approved for commit, LGTM.

This revision is now accepted and ready to land.Sat, Sep 26, 5:16 PM
jrm accepted this revision.Sat, Sep 26, 5:26 PM

lgtm

Closed by commit R11:f58e5c3241f4: x11/bosd: Add EXAMPLES option (authored by dteske). · Explain WhySat, Sep 26, 6:13 PM
This revision was automatically updated to reflect the committed changes.
dteske added a commit: R11:f58e5c3241f4: x11/bosd: Add EXAMPLES option.

Revision Contents
Changeset List

PathSize
x11/
bosd/
12 lines
16 lines

Diff 187754

View Options

x11/bosd/Makefile

Loading...
View Options

x11/bosd/pkg-plist

Loading...