Page MenuHomeFreeBSD

x11/bosd: Add EXAMPLES option
Needs ReviewPublic

Authored by dteske on Thu, Sep 24, 3:22 PM.
Tags
None
Referenced Files
F173434913: D59989.id187686.diff
Fri, Sep 25, 10:17 PM
F173417463: D59989.id187679.diff
Fri, Sep 25, 7:56 PM
F173389669: D59989.diff
Fri, Sep 25, 3:44 PM
F173387344: D59989.diff
Fri, Sep 25, 3:23 PM
Unknown Object (File)
Fri, Sep 25, 1:11 AM
Unknown Object (File)
Fri, Sep 25, 12:48 AM
Unknown Object (File)
Thu, Sep 24, 10:29 PM
Unknown Object (File)
Thu, Sep 24, 9:02 PM
Subscribers
None

Details

Reviewers
fuz
jrm
Summary

Install the sample glyph scripts only when EXAMPLES is on. The
glyph PNGs stay in the icon directory.

Suggested by: fuz

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 77281
Build 74164: arc lint + arc unit

Event Timeline

dteske created this revision.

LGTM, and please bump PORTREVISION for this change.
Approved for commit.

This revision is now accepted and ready to land.Fri, Sep 25, 9:55 AM

Bump PORTREVISION as requested. Add TESTS_DESC so portlint is clean.

This revision now requires review to proceed.Fri, Sep 25, 3:37 PM

Bump PORTREVISION (fuz), add description for TESTS (portlint)

x11/bosd/Makefile
14

Is the python run-time dependency only for the example scripts? If so, you could make it conditional.

EXAMPLES_USES=        python:build,run
EXAMPLES_USES_OFF=    python:build
x11/bosd/Makefile
14

Good catch.

I initially meant to make share/examples/bosd/glyph.py u conditional but because it is in the examples dir, it got swept up in the other examples becoming conditional.

I may move glyph.py out of the examples dir or I might make the runtime dependency on Python conditional as you suggest. I need to think on which I will do