Page MenuHomeFreeBSD
Differential D59939

acpi/apm: Don't claim silent success for APMIO_BIOS ioctls
ClosedPublic
Actions

Authored by jhb on Wed, Sep 23, 7:06 PM.
Tags
None
Referenced Files
F174107659: D59939.id187530.diff
Wed, Sep 30, 4:36 PM
F174107657: D59939.id.diff
Wed, Sep 30, 4:36 PM
Unknown Object (File)
Wed, Sep 30, 8:59 AM
Unknown Object (File)
Wed, Sep 30, 6:15 AM
Unknown Object (File)
Wed, Sep 30, 6:15 AM
Unknown Object (File)
Wed, Sep 30, 5:57 AM
Unknown Object (File)
Wed, Sep 30, 1:57 AM
Unknown Object (File)
Tue, Sep 29, 11:46 PM
View All 22 Files
Subscribers
None

Details

Reviewers
imp
Commits
rG1d7f0c742863: acpi/apm: Don't claim silent success for APMIO_BIOS ioctls
Summary

Report failure as if the request had failed. This causes apm(8) to
correctly report the resume timer as "unknown" rather than random
garbage.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 77222
Build 74105: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Wed, Sep 23, 7:06 PM
jhb created this revision.
jhb added a parent revision: D59938: apm.4: Trim down to describing the compat interface exposed by acpi(4).
Harbormaster completed remote builds in B77222: Diff 187530.Wed, Sep 23, 7:06 PM
jhb added a child revision: D59940: acpi/apm: Store the ACPI softc in si_drv1.Wed, Sep 23, 7:06 PM
jhb added a comment.Wed, Sep 23, 7:09 PM

Verified that apm(8) on my X1 Carbon no longer outputs garbage for the resume timer state with this fix.

imp accepted this revision.Wed, Sep 23, 9:10 PM
This revision is now accepted and ready to land.Wed, Sep 23, 9:10 PM
Closed by commit rG1d7f0c742863: acpi/apm: Don't claim silent success for APMIO_BIOS ioctls (authored by jhb). · Explain WhyWed, Sep 30, 4:27 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG1d7f0c742863: acpi/apm: Don't claim silent success for APMIO_BIOS ioctls.

Revision Contents
Changeset List

PathSize
sys/
x86/
acpica/
3 lines

Diff 187530

View Options

sys/x86/acpica/acpi_apm.c

Loading...