Page MenuHomeFreeBSD
Differential D59664

Add a BUILD_RUN_DEPENDS variable
ClosedPublic
Actions

Authored by mat on Mon, Sep 14, 1:33 PM.
Tags
None
Referenced Files
F175226287: D59664.id186677.diff
Fri, Oct 9, 6:19 AM
Unknown Object (File)
Tue, Oct 6, 4:40 AM
Unknown Object (File)
Sun, Oct 4, 11:26 AM
Unknown Object (File)
Sat, Oct 3, 7:05 PM
Unknown Object (File)
Sat, Oct 3, 1:04 PM
Unknown Object (File)
Sat, Oct 3, 6:59 AM
Unknown Object (File)
Sat, Oct 3, 6:59 AM
Unknown Object (File)
Sat, Oct 3, 5:33 AM
View All 60 Files
Subscribers
dvl
fuz

Details

Reviewers
None
Group Reviewers
portmgr
Commits
R11:07679900322e: Mk: add a BUILD_RUN_DEPENDS variable

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mat requested review of this revision.Mon, Sep 14, 1:33 PM
mat created this revision.
mat updated this revision to Diff 186677.Mon, Sep 14, 2:28 PM
mat updated this revision to Diff 186679.Mon, Sep 14, 2:30 PM
dvl added a subscriber: dvl.Mon, Sep 14, 2:35 PM

I'm guessing you want to implement this ASAP to get it in use.

I will amend FreshPorts to extract this variable. If I got that work done before this change goes into use, it would capture all future uses. If I don't, it's just a one-off script to refresh the database from the ports tree.

NOTE: I'm just thinking out loud because it helps my planning process.
mat added a comment.EditedMon, Sep 14, 4:04 PM
In D59664#1369215, @dvl wrote:

I'm guessing you want to implement this ASAP to get it in use.

I will amend FreshPorts to extract this variable. If I got that work done before this change goes into use, it would capture all future uses. If I don't, it's just a one-off script to refresh the database from the ports tree.

NOTE: I'm just thinking out loud because it helps my planning process.

I don't think freshports needs to extract this, you can keep using build/run, it is only to be used as some kind of syntaxic sugar, and it's mostly to avoid people doing RUN_DEPENDS=BUILD_DEPENDS.

fuz added a subscriber: fuz.Tue, Sep 15, 11:06 AM

I like it!

dvl added a comment.Tue, Sep 15, 11:41 PM

FYI, I have code changes in place everywhere but prod. I'm letting them run before updating prod tomorrow. If this could hold off until after that, I would appreciate it as it would avoid work for me. Thanks.

dvl added a comment.Tue, Sep 15, 11:44 PM

I don't think freshports needs to extract this, you can keep using build/run, it is only to be used as some kind of syntaxic sugar, and it's mostly to avoid people doing RUN_DEPENDS=BUILD_DEPENDS.

oops. I just saw this.

Are you saying that make -V RUN_DEPENDS will still pull back the usual stuff? Same with make -V BUILD_DEPENDS ... hmm.

mat added a comment.Wed, Sep 16, 5:27 AM
In D59664#1370294, @dvl wrote:

Are you saying that make -V RUN_DEPENDS will still pull back the usual stuff? Same with make -V BUILD_DEPENDS ... hmm.

It's exactly what the patch does, put BUILD_RUN_DEPENDS into BUILD_DEPENDS and RUN_DEPENDS.

fuz mentioned this in D22677: devel/R-cran-bigmemory: New port.Wed, Sep 16, 10:49 AM
dvl added a comment.Wed, Sep 16, 2:41 PM

What happens if a Makefile contains:

BUILD_RUN_DEPENDS=...
BUILD_DEPENDS=...
RUN_DPENDS=...

What also comes to mind is:

This revision was not accepted when it landed; it landed in state Needs Review.Wed, Sep 23, 12:11 PM
Closed by commit R11:07679900322e: Mk: add a BUILD_RUN_DEPENDS variable (authored by mat). · Explain Why
This revision was automatically updated to reflect the committed changes.
mat added a commit: R11:07679900322e: Mk: add a BUILD_RUN_DEPENDS variable.

Revision Contents
Changeset List

PathSize
6 lines
Mk/
5 lines

Diff 187498

View Options

CHANGES

Loading...
View Options

Mk/bsd.port.mk

Loading...