Page MenuHomeFreeBSD

Add a BUILD_RUN_DEPENDS variable
Needs ReviewPublic

Authored by mat on Mon, Sep 14, 1:33 PM.
Tags
None
Referenced Files
F172117064: D59664.diff
Wed, Sep 16, 6:32 AM
F172035036: D59664.id.diff
Tue, Sep 15, 2:37 PM
F172024326: D59664.id186679.diff
Tue, Sep 15, 11:59 AM
Unknown Object (File)
Tue, Sep 15, 12:56 AM
Unknown Object (File)
Mon, Sep 14, 11:49 PM
Unknown Object (File)
Mon, Sep 14, 11:42 PM
Unknown Object (File)
Mon, Sep 14, 11:39 PM
Unknown Object (File)
Mon, Sep 14, 10:05 PM
Subscribers

Details

Reviewers
None
Group Reviewers
portmgr

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

mat requested review of this revision.Mon, Sep 14, 1:33 PM
mat created this revision.

I'm guessing you want to implement this ASAP to get it in use.

I will amend FreshPorts to extract this variable. If I got that work done before this change goes into use, it would capture all future uses. If I don't, it's just a one-off script to refresh the database from the ports tree.

NOTE: I'm just thinking out loud because it helps my planning process.
In D59664#1369215, @dvl wrote:

I'm guessing you want to implement this ASAP to get it in use.

I will amend FreshPorts to extract this variable. If I got that work done before this change goes into use, it would capture all future uses. If I don't, it's just a one-off script to refresh the database from the ports tree.

NOTE: I'm just thinking out loud because it helps my planning process.

I don't think freshports needs to extract this, you can keep using build/run, it is only to be used as some kind of syntaxic sugar, and it's mostly to avoid people doing RUN_DEPENDS=BUILD_DEPENDS.

FYI, I have code changes in place everywhere but prod. I'm letting them run before updating prod tomorrow. If this could hold off until after that, I would appreciate it as it would avoid work for me. Thanks.

I don't think freshports needs to extract this, you can keep using build/run, it is only to be used as some kind of syntaxic sugar, and it's mostly to avoid people doing RUN_DEPENDS=BUILD_DEPENDS.

oops. I just saw this.

Are you saying that make -V RUN_DEPENDS will still pull back the usual stuff? Same with make -V BUILD_DEPENDS ... hmm.

In D59664#1370294, @dvl wrote:

Are you saying that make -V RUN_DEPENDS will still pull back the usual stuff? Same with make -V BUILD_DEPENDS ... hmm.

It's exactly what the patch does, put BUILD_RUN_DEPENDS into BUILD_DEPENDS and RUN_DEPENDS.