Page MenuHomeFreeBSD
Differential D59673

amdsmu: Diagnose S0i3 entry after resume
ClosedPublic
Actions

Authored by obiwac on Mon, Sep 14, 6:31 PM.
Tags
None
Referenced Files
F172579609: D59673.id187080.diff
Sat, Sep 19, 10:22 AM
F172499577: D59673.id187080.diff
Fri, Sep 18, 9:26 PM
Unknown Object (File)
Fri, Sep 18, 7:51 PM
Unknown Object (File)
Thu, Sep 17, 10:25 PM
Unknown Object (File)
Thu, Sep 17, 8:49 PM
Unknown Object (File)
Thu, Sep 17, 8:33 PM
Unknown Object (File)
Thu, Sep 17, 7:56 PM
Unknown Object (File)
Thu, Sep 17, 7:54 PM
View All 25 Files
Subscribers
imp

Details

Reviewers
olce
Commits
rGa23fa3fe1c0a: amdsmu: Diagnose S0i3 entry after resume
Summary

Print out diagnostic information after resuming from suspend-to-idle if
we failed to enter S0i3, i.e. the IP blocks that were blocking entry to
S0i3.

Don't give detailed IP block info for other SMUs than for Phoenix, as I
have not had a chance to test these yet and the SMU seems to be very
quirky.

Sponsored by: The FreeBSD Foundation

Test Plan

Purposely prevent S0i3 entry by e.g. not loading thunderbolt(4) or amdgpu and see if amdsmu(4) correctly reports the equivalent IP blocks after resuming from suspend-to-idle.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 76996
Build 73879: arc lint + arc unit

Event Timeline

obiwac created this revision.Mon, Sep 14, 6:31 PM
Herald added a subscriber: imp. · View Herald TranscriptMon, Sep 14, 6:31 PM
obiwac requested review of this revision.Mon, Sep 14, 6:31 PM
Harbormaster completed remote builds in B76892: Diff 186706.Mon, Sep 14, 6:31 PM
obiwac added a parent revision: D59672: acpi: Warn if no amdsmu(4) loaded after suspend-to-idle resume.Mon, Sep 14, 6:32 PM
obiwac updated this revision to Diff 186707.Mon, Sep 14, 6:44 PM

only give IP block detail for Phoenix

Harbormaster completed remote builds in B76893: Diff 186707.Mon, Sep 14, 6:44 PM
obiwac edited the summary of this revision. (Show Details)Mon, Sep 14, 6:45 PM
obiwac updated this revision to Diff 186708.Mon, Sep 14, 6:53 PM

IP block can have active time but not be blocking, actually

Harbormaster completed remote builds in B76894: Diff 186708.Mon, Sep 14, 6:53 PM
obiwac mentioned this in D59674: amdsmu: Hints on what to do if IP block blocking S0i3.Mon, Sep 14, 6:56 PM
obiwac added a child revision: D59674: amdsmu: Hints on what to do if IP block blocking S0i3.Mon, Sep 14, 6:57 PM
obiwac updated this revision to Diff 186909.Wed, Sep 16, 6:53 PM

rebase & use new power_resume_check eventhandler

Harbormaster completed remote builds in B76996: Diff 186909.Wed, Sep 16, 6:53 PM
obiwac added a parent revision: D59740: power: Add power_resume_check eventhandler.Wed, Sep 16, 6:53 PM
obiwac edited parent revisions, added: D59741: acpi: Invoke power_resume_check eventhandler; removed: D59740: power: Add power_resume_check eventhandler.Wed, Sep 16, 7:02 PM
olce accepted this revision.Fri, Sep 18, 7:34 AM
This revision is now accepted and ready to land.Fri, Sep 18, 7:34 AM
Closed by commit rGa23fa3fe1c0a: amdsmu: Diagnose S0i3 entry after resume (authored by obiwac). · Explain WhyFri, Sep 18, 11:00 AM
This revision was automatically updated to reflect the committed changes.
obiwac added a commit: rGa23fa3fe1c0a: amdsmu: Diagnose S0i3 entry after resume.

Revision Contents
Changeset List

PathSize
sys/
dev/
amdsmu/
1 line
48 lines

Diff 186909

View Options

sys/dev/amdsmu/amdsmu.h

Loading...
View Options

sys/dev/amdsmu/amdsmu.c

Loading...