snd_uaudio: Read the UAC2 sample rate back after setting it
ClosedPublic
Actions

Authored by christos on Sat, Sep 12, 12:55 PM.

Details

Reviewers

markj
emaste

Commits

rG77b75400324d: snd_uaudio: Read the UAC2 sample rate back after setting it
rG694923501f56: snd_uaudio: Read the UAC2 sample rate back after setting it

Summary

Some devices only apply a new sample rate once it has been read back,
and produce no sound at all otherwise.

PR: 294803
Reported by: tatsuki_makino@hotmail.com
Tested by: tatsuki_makino@hotmail.com
MFC after: 2 weeks
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

christos created this revision.Sat, Sep 12, 12:55 PM

Herald added a subscriber: imp. · View Herald TranscriptSat, Sep 12, 12:55 PM

christos requested review of this revision.Sat, Sep 12, 12:55 PM

Harbormaster completed remote builds in B76797: Diff 186516.Sat, Sep 12, 12:55 PM

The bug reporter has confirmed the patch works.

emaste accepted this revision.Sat, Sep 12, 1:09 PM

This revision is now accepted and ready to land.Sat, Sep 12, 1:09 PM

Closed by commit rG694923501f56: snd_uaudio: Read the UAC2 sample rate back after setting it (authored by christos). · Explain WhyTue, Sep 15, 12:13 PM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rG694923501f56: snd_uaudio: Read the UAC2 sample rate back after setting it.

christos added a commit: rG77b75400324d: snd_uaudio: Read the UAC2 sample rate back after setting it.Tue, Sep 29, 10:16 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

usb/

uaudio.c

23 lines

Diff 186764

View Options

sys/dev/sound/usb/uaudio.c

snd_uaudio: Read the UAC2 sample rate back after setting itClosedPublicActions