Page MenuHomeFreeBSD

java/openjdk27: Add port
ClosedPublic

Authored by haraldei on Wed, Sep 9, 7:14 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 24, 7:36 PM
Unknown Object (File)
Thu, Sep 24, 7:36 PM
Unknown Object (File)
Wed, Sep 23, 10:29 AM
Unknown Object (File)
Wed, Sep 23, 3:36 AM
Unknown Object (File)
Tue, Sep 22, 11:19 PM
Unknown Object (File)
Mon, Sep 21, 6:23 AM
Unknown Object (File)
Mon, Sep 21, 4:25 AM
Unknown Object (File)
Sun, Sep 20, 11:59 PM
Subscribers
None

Details

Summary

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 76874
Build 73757: arc lint + arc unit

Event Timeline

haraldei created this revision.

OpenJDK27 will be released by upstream on Sept 15. It's most likely going to be the version tagged here, but if there's any updates I'll update the patch.

I'll also update the commit message with links to the upstream release notes and changelogs as well.

pkubaj requested changes to this revision.Wed, Sep 9, 9:05 AM

Two patches are necessary on powerpc64*:

--- src/hotspot/os_cpu/bsd_ppc/prefetch_bsd_ppc.inline.hpp.orig 2026-09-03 11:42:54 UTC
+++ src/hotspot/os_cpu/bsd_ppc/prefetch_bsd_ppc.inline.hpp
@@ -26,8 +26,6 @@
 #ifndef OS_CPU_BSD_PPC_VM_PREFETCH_BSD_PPC_INLINE_HPP
 #define OS_CPU_BSD_PPC_VM_PREFETCH_BSD_PPC_INLINE_HPP

-#include "runtime/prefetch.hpp"
-

 inline void Prefetch::read(const void *loc, intx interval) {
   __asm__ __volatile__ (
--- src/hotspot/os_cpu/bsd_ppc/vm_version_bsd_ppc.cpp.orig  2026-09-03 11:42:54 UTC
+++ src/hotspot/os_cpu/bsd_ppc/vm_version_bsd_ppc.cpp
@@ -0,0 +1,47 @@
+/*
+ * Copyright (c) 1997, 2025, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2012, 2025 SAP SE. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ *
+ */
+
+#include "runtime/vm_version.hpp"
+
+#include <sys/types.h>
+#include <sys/sysctl.h>
+
+// FreeBSD exposes a single PPC coherency block size covering both caches.
+static int cacheline_size() {
+  int size = 0;
+  size_t len = sizeof(size);
+  if (sysctlbyname("machdep.cacheline_size", &size, &len, nullptr, 0) != 0 || size <= 0) {
+    return DEFAULT_CACHE_LINE_SIZE;
+  }
+  return size;
+}
+
+int VM_Version::get_dcache_line_size() {
+  return cacheline_size();
+}
+
+int VM_Version::get_icache_line_size() {
+  return cacheline_size();
+}
This revision now requires changes to proceed.Wed, Sep 9, 9:05 AM

Also, PORTREVISION shouldn't be set for a new port.

Also, PORTREVISION shouldn't be set for a new port.

Ah! I knew that! Thanks for spotting it :)

--- src/hotspot/os_cpu/bsd_ppc/vm_version_bsd_ppc.cpp.orig  2026-09-03 11:42:54 UTC
+++ src/hotspot/os_cpu/bsd_ppc/vm_version_bsd_ppc.cpp
@@ -0,0 +1,47 @@
+/*
+ * Copyright (c) 1997, 2025, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2012, 2025 SAP SE. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.

These copyright headers seem wrong, since this is your work.

Corrected:

--- src/hotspot/os_cpu/bsd_ppc/vm_version_bsd_ppc.cpp.orig  2026-09-03 11:42:54 UTC
+++ src/hotspot/os_cpu/bsd_ppc/vm_version_bsd_ppc.cpp
@@ -0,0 +1,46 @@
+/*
+ * Copyright (c) 2026, Piotr Kubaj. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ *
+ */
+
+#include "runtime/vm_version.hpp"
+
+#include <sys/types.h>
+#include <sys/sysctl.h>
+
+// FreeBSD exposes a single PPC coherency block size covering both caches.
+static int cacheline_size() {
+  int size = 0;
+  size_t len = sizeof(size);
+  if (sysctlbyname("machdep.cacheline_size", &size, &len, nullptr, 0) != 0 || size <= 0) {
+    return DEFAULT_CACHE_LINE_SIZE;
+  }
+  return size;
+}
+
+int VM_Version::get_dcache_line_size() {
+  return cacheline_size();
+}
+
+int VM_Version::get_icache_line_size() {
+  return cacheline_size();
+}

Bumb build num and add extra patch for PPC64 build

@pkubaj Could you please check if this is ok now? Thanks!

pkubaj requested changes to this revision.Mon, Sep 21, 10:49 AM

It looks like you're still missing one patch mentioned previously:

--- src/hotspot/os_cpu/bsd_ppc/prefetch_bsd_ppc.inline.hpp.orig 2026-09-03 11:42:54 UTC
+++ src/hotspot/os_cpu/bsd_ppc/prefetch_bsd_ppc.inline.hpp
@@ -26,8 +26,6 @@
 #ifndef OS_CPU_BSD_PPC_VM_PREFETCH_BSD_PPC_INLINE_HPP
 #define OS_CPU_BSD_PPC_VM_PREFETCH_BSD_PPC_INLINE_HPP

-#include "runtime/prefetch.hpp"
-

 inline void Prefetch::read(const void *loc, intx interval) {
   __asm__ __volatile__ (
This revision now requires changes to proceed.Mon, Sep 21, 10:49 AM

It looks like you're still missing one patch mentioned previously:

--- src/hotspot/os_cpu/bsd_ppc/prefetch_bsd_ppc.inline.hpp.orig 2026-09-03 11:42:54 UTC
+++ src/hotspot/os_cpu/bsd_ppc/prefetch_bsd_ppc.inline.hpp
@@ -26,8 +26,6 @@
 #ifndef OS_CPU_BSD_PPC_VM_PREFETCH_BSD_PPC_INLINE_HPP
 #define OS_CPU_BSD_PPC_VM_PREFETCH_BSD_PPC_INLINE_HPP

-#include "runtime/prefetch.hpp"
-

 inline void Prefetch::read(const void *loc, intx interval) {
   __asm__ __volatile__ (

This one is included in the base repo. https://github.com/freebsd/openjdk/commit/3d34fd5b5a220e8e002ad35cc64b8c31b0c17c64

This revision is now accepted and ready to land.Mon, Sep 21, 12:40 PM
This revision was automatically updated to reflect the committed changes.