Paths

Table of Contentst

Differential D59588

chflags: Alias nocache to noucache for consistency
ClosedPublic
Actions

Authored by ziaee on Fri, Sep 11, 12:14 PM.

Tags

None

Referenced Files

	F172529165: D59588.id186457.diff
	Sat, Sep 19, 1:50 AM

	F172525775: D59588.id186584.diff
	Sat, Sep 19, 1:21 AM

	F172493888: D59588.id186584.diff
	Fri, Sep 18, 8:34 PM

	F172493486: D59588.id186577.diff
	Fri, Sep 18, 8:30 PM

	Unknown Object (File)
	Fri, Sep 18, 6:13 PM

	Unknown Object (File)
	Fri, Sep 18, 9:29 AM

	Unknown Object (File)
	Thu, Sep 17, 10:06 AM

	Unknown Object (File)
	Wed, Sep 16, 5:07 PM

View All 27 Files

Subscribers

Details

Reviewers

fuz
rmacklem

Commits

rG49b4137da6ea: chflags: Alias nocache to noucache for consistency

Summary

Requested by: fuz

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 76771
Build 73654: arc lint + arc unit

Event Timeline

ziaee created this revision.Fri, Sep 11, 12:14 PM

Herald added a subscriber: imp. · View Herald TranscriptFri, Sep 11, 12:14 PM

ziaee requested review of this revision.Fri, Sep 11, 12:14 PM

Harbormaster completed remote builds in B76771: Diff 186457.Fri, Sep 11, 12:14 PM

fuz added inline comments.Fri, Sep 11, 1:10 PM

lib/libc/gen/strtofflags.c
84–90	Try this, should build fine and avoids the duplicated `nousystem` line.

rmacklem accepted this revision.Fri, Sep 11, 1:39 PM

rmacklem added inline comments.

lib/libc/gen/strtofflags.c
84–90	You can do so, but I did it the way I did it to maintain a consistent style. style(9) says that style should only be changed for major re-writes. But choose whichever way you prefer.

This revision is now accepted and ready to land.Fri, Sep 11, 1:39 PM

Accepted subject to the changes I have proposed.

lib/libc/gen/strtofflags.c
84–90	It's not really a style change. More of a simplification of lines that'll be touched anyway.

so like this?

This revision now requires review to proceed.Sun, Sep 13, 10:14 AM

Harbormaster completed remote builds in B76826: Diff 186577.Sun, Sep 13, 10:14 AM

Looks good!
Approved for src.

This revision is now accepted and ready to land.Sun, Sep 13, 11:17 AM

Closed by commit rG49b4137da6ea: chflags: Alias nocache to noucache for consistency (authored by ziaee). · Explain WhySun, Sep 13, 11:43 AM

This revision was automatically updated to reflect the committed changes.

ziaee added a commit: rG49b4137da6ea: chflags: Alias nocache to noucache for consistency.

Revision Contents
Changeset List

Path

Size

bin/

chflags/

2 lines

lib/

libc/

gen/

1 line

Diff 186457

bin/chflags/chflags.1

Loading...

lib/libc/gen/strtofflags.c

Loading...