linuxkpi: Correct nents passed to dma_{un,}map_sg_attrs
ClosedPublic
Actions

Authored by zishun.yi.dev_gmail.com on Jun 25 2026, 1:28 PM.

Details

Reviewers

Group Reviewers

Commits

rG091ca09a0a66: LinuxKPI: Correct nents passed to dma_{un,}map_sg_attrs()
rG33574d47d9de: LinuxKPI: Correct nents passed to dma_{un,}map_sg_attrs()

Summary

In linux docs, there is:

void
dma_unmap_sg(struct device *dev, struct scatterlist *sg,
             int nents, enum dma_data_direction direction)
Note: <nents> must be the number you passed in, not the number of DMA
address entries returned.

but I think currently nents is equal to orig_nents in linuxkpi. So It's
just a trivial fix.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

zishun.yi.dev_gmail.com created this revision.Jun 25 2026, 1:28 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptJun 25 2026, 1:28 PM

zishun.yi.dev_gmail.com requested review of this revision.Jun 25 2026, 1:28 PM

zishun.yi.dev_gmail.com edited the summary of this revision. (Show Details)Jun 25 2026, 1:29 PM

Harbormaster completed remote builds in B74247: Diff 180620.Jun 25 2026, 1:30 PM

emaste added a project: linuxkpi.Aug 17 2026, 4:59 PM

LGTM!

I believe this is a NOP but more correct.

This revision is now accepted and ready to land.Aug 22 2026, 10:30 PM

Closed by commit rG33574d47d9de: LinuxKPI: Correct nents passed to dma_{un,}map_sg_attrs() (authored by zishun.yi.dev_gmail.com, committed by bz). · Explain WhySun, Sep 6, 12:14 AM

This revision was automatically updated to reflect the committed changes.

bz added a commit: rG33574d47d9de: LinuxKPI: Correct nents passed to dma_{un,}map_sg_attrs().

bz added a commit: rG091ca09a0a66: LinuxKPI: Correct nents passed to dma_{un,}map_sg_attrs().Thu, Sep 10, 9:50 AM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

dma-mapping.h

4 lines

Diff 185985

View Options

sys/compat/linuxkpi/common/include/linux/dma-mapping.h

linuxkpi: Correct nents passed to dma_{un,}map_sg_attrsClosedPublicActions