Page MenuHomeFreeBSD

bectl: stop pretending that jailparam_delarg can fail
AcceptedPublic

Authored by kevans on Sat, Sep 5, 3:45 AM.
Tags
None
Referenced Files
F171054220: D59439.diff
Tue, Sep 8, 10:39 AM
Unknown Object (File)
Sat, Sep 5, 6:12 PM
Unknown Object (File)
Sat, Sep 5, 6:12 PM
Unknown Object (File)
Sat, Sep 5, 2:22 PM
Unknown Object (File)
Sat, Sep 5, 8:08 AM
Unknown Object (File)
Sat, Sep 5, 5:15 AM
Unknown Object (File)
Sat, Sep 5, 5:04 AM
Subscribers

Details

Reviewers
ngie
rew
Summary

Its only failure mode was name == NULL, but we only ever pass in
optarg from a required-argument flag. Drop the pretense and convert
that conditional to an assertion, because it's actually actively
harmful: GCC 14, at least, will deduce that the error path means that
optarg can be NULL and raise a warning about passing NULL to an %s
specifier.

PR: 298192

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 76560
Build 73443: arc lint + arc unit