Ping? Sorry for the hurry, but I would like to get this into 11.

I don't know the interaction between vga and vesa here and how all those functions are called and in which order.

I suppose vesa_load() is not called at all in the code path you hit. But can't you use it as vga_sub_configure?

In D7196#150638, @dumbbell wrote:

I don't know the interaction between vga and vesa here and how all those functions are called and in which order.

I suppose vesa_load() is not called at all in the code path you hit. But can't you use it as vga_sub_configure?

The problem with using vesa_load directly is that it doesn't take any parameter, while vga_sub_configure takes a flags parameter. What I could probably do is make vesa_load call vesa_late_load with an empty flags parameter, does that sound better?

Or the reverse: vesa_late_load(flags) calls vesa_load()? Just to avoid code duplication.

But my suggestion could be wrong: vesa_load() checks vesa_init_done and nullifies vesa_adp. I don't know the code enough :(

In D7196#150652, @dumbbell wrote:

Or the reverse: vesa_late_load(flags) calls vesa_load()? Just to avoid code duplication.

But my suggestion could be wrong: vesa_load() checks vesa_init_done and nullifies vesa_adp. I don't know the code enough :(

vesa_late_load cannot call vesa_load because vesa_load cannot take any parameter, and vesa_late_load needs to pass the flags parameter around.

AFAICT, when vesa_late_load (vga_sub_configure) is called vesa_adp should be null and vesa_init_done should be 0, or else there's something wrong going on.

IMHO, the best solution is to rename vesa_load to vesa_late_load (adding a flags parameter), and turn vesa_load into a wrapper that just calls vesa_late_load.

Ok, thanks for the explanation. Sorry I missed that flags was passed to vesa_configure().

Your idea looks good.