tarfs_test: split large file test into independent cases
ClosedPublic
Actions

Authored by siva on Aug 20 2026, 7:24 AM.

Details

Reviewers

des
stevek

Commits

rGc528a152be7e: tarfs_test: split large file test into independent cases
rG34c40126fd10: tarfs_test: split large file test into independent cases

Summary

This avoids globally set timeouts for the group of
tarfs_large tests on slower emulated architectures.

While here, lower each testcase's timeout to reflect
the reduction of work. On QEMU aarch64, the largest case
runs in ~500s on a modern desktop, so double that for a
conservative estimate.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 76472
Build 73355: arc lint + arc unit

Event Timeline

siva created this revision.Aug 20 2026, 7:24 AM

Herald added a subscriber: imp. · View Herald TranscriptAug 20 2026, 7:24 AM

siva requested review of this revision.Aug 20 2026, 7:24 AM

Harbormaster completed remote builds in B75778: Diff 184444.Aug 20 2026, 7:24 AM

Generating tests at run time (and especially generating them from atf_init_test_cases()) is problematic because the script gets run more than once per test case, so we keep generating code over and over even when we don't need it. I would prefer multiple thin hand-written wrappers around tarfs_large_test().

Use hand written thin wrappers instead of dynamically generating test cases.

Harbormaster completed remote builds in B76471: Diff 185774.Sep 3 2026, 10:22 PM

Fix formatting

Harbormaster completed remote builds in B76472: Diff 185775.Sep 3 2026, 10:26 PM

des added inline comments.Sep 4 2026, 9:15 AM

tests/sys/fs/tarfs/tarfs_test.sh
418–426	Do you really need two test cases for each shift value or can you merge them?

siva added inline comments.Sep 5 2026, 2:27 AM

tests/sys/fs/tarfs/tarfs_test.sh
418–426	Mounting and unmounting is the bottleneck here, and you'd have to do that twice anyway if we merge the two cases. Why would we do it sequentially rather than concurrently if they are independent? It's just a few more (static) lines of sh to keep it.