Page MenuHomeFreeBSD
Differential D59364

pmc(8): zero-initialize the event descriptor in stat mode
Needs ReviewPublic
Actions

Authored by afscoelho_gmail.com on Sep 3 2026, 9:32 PM.
Tags
None
Referenced Files
F174665058: D59364.id188466.diff
Mon, Oct 5, 1:31 AM
Unknown Object (File)
Sun, Oct 4, 3:30 AM
Unknown Object (File)
Sun, Oct 4, 1:23 AM
Unknown Object (File)
Sat, Oct 3, 5:59 AM
Unknown Object (File)
Sat, Oct 3, 5:20 AM
Unknown Object (File)
Sat, Oct 3, 4:22 AM
Unknown Object (File)
Sat, Oct 3, 3:39 AM
Unknown Object (File)
Sat, Oct 3, 3:37 AM
View All 49 Files
Subscribers
imp

Details

Reviewers
ali_mashtizadeh.com
anascime_amd.com
ojanerif_amd.com
davichazbh_gmail.com
Group Reviewers
pmc
Summary

cmd_pmc_stat allocated the event descriptor with malloc and then set
only some of its fields, so the rest held whatever was on the heap.
Use calloc.

This is an independent fix. It does not depend on the PMU grouping
work, and can be committed on its own.

Sponsored by: AMD

Signed-off-by: Andre Silva <andasilv@amd.com>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 76458
Build 73341: arc lint + arc unit

Event Timeline

afscoelho_gmail.com created this revision.Sep 3 2026, 9:32 PM
afscoelho_gmail.com held this revision as a draft.
Herald added a reviewer: ali_mashtizadeh.com. · View Herald TranscriptSep 3 2026, 9:32 PM
Herald added a subscriber: imp. · View Herald Transcript
Harbormaster completed remote builds in B76458: Diff 185761.Sep 3 2026, 9:32 PM
afscoelho_gmail.com added a parent revision: D59363: pmcstat(8): warn about unfittable grouped sample periods.Sep 3 2026, 9:33 PM
afscoelho_gmail.com added a child revision: D59365: pmc, pmcstat: document PMU event grouping.
afscoelho_gmail.com published this revision for review.Tue, Sep 8, 12:36 PM
afscoelho_gmail.com added a reviewer: pmc.Tue, Sep 8, 3:34 PM
afscoelho_gmail.com edited the summary of this revision. (Show Details)
afscoelho_gmail.com added reviewers: anascime_amd.com, ojanerif_amd.com, davichazbh_gmail.com.Thu, Sep 10, 12:45 PM
afscoelho_gmail.com updated this revision to Diff 188103.Tue, Sep 29, 7:38 PM

Rebase onto main after D58256 landed.

Harbormaster completed remote builds in B77479: Diff 188103.Tue, Sep 29, 7:38 PM
afscoelho_gmail.com updated this revision to Diff 188251.Wed, Sep 30, 9:07 PM

Rebase only. No change.

Harbormaster completed remote builds in B77546: Diff 188251.Wed, Sep 30, 9:07 PM
afscoelho_gmail.com updated this revision to Diff 188466.Fri, Oct 2, 6:39 PM

Rebase on main (D60141 and D60185 are committed). No change.

Harbormaster completed remote builds in B77640: Diff 188466.Fri, Oct 2, 6:39 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
pmc/
2 lines

Diff 185761

View Options

usr.sbin/pmc/cmd_pmc_stat.c

Loading...