Page MenuHomeFreeBSD
Differential D59304

java/openjdk{25,26}: portclippy and cleanup
AcceptedPublic
Actions

Authored by haraldei on Sep 1 2026, 1:50 PM.
Tags
None
Referenced Files
F174916073: D59304.id185618.diff
Tue, Oct 6, 11:05 PM
F174839858: D59304.id185617.diff
Tue, Oct 6, 10:10 AM
Unknown Object (File)
Tue, Oct 6, 6:37 AM
Unknown Object (File)
Tue, Oct 6, 3:25 AM
Unknown Object (File)
Mon, Oct 5, 11:19 AM
Unknown Object (File)
Sun, Oct 4, 6:09 PM
Unknown Object (File)
Sat, Oct 3, 6:23 PM
Unknown Object (File)
Sat, Oct 3, 4:22 AM
View All 68 Files
Subscribers
None

Details

Reviewers
vsasjason_gmail.com
glewis
emaste
jrm
Summary

Just a cleanup commit sorting the Makefile according to portclippy
suggestions, and reducing the number of times we check for a headless
build, as suggested by vsasjason_gmail.com.

This commit does not increase the PORTREVISION as it does not introduce
any changes to functionality or dependencies.

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 76402
Build 73285: arc lint + arc unit

Event Timeline

haraldei requested review of this revision.Sep 1 2026, 1:50 PM
haraldei created this revision.
Harbormaster completed remote builds in B76375: Diff 185559.Sep 1 2026, 1:50 PM
jrm added inline comments.Sep 1 2026, 2:38 PM
java/openjdk25/Makefile
43

typo: s/Jave/Java/

62–63

You need a TAB instead of spaces after the = here.

java/openjdk26/Makefile
43

typo: s/Jave/Java/

50–51

Two consecutive blank lines here.

63–64

You need a TAB instead of spaces after the = here.

haraldei updated this revision to Diff 185617.Sep 2 2026, 9:46 AM

Fix typo and tab-alignment

Harbormaster completed remote builds in B76402: Diff 185617.Sep 2 2026, 9:46 AM
haraldei updated this revision to Diff 185618.Sep 2 2026, 9:48 AM

...and the double newline

Harbormaster completed remote builds in B76403: Diff 185618.Sep 2 2026, 9:48 AM
haraldei marked 5 inline comments as done.Sep 2 2026, 9:49 AM
vsasjason_gmail.com added a comment.Sep 3 2026, 11:25 AM
In D59304#1361038, @haraldei wrote:

Fix typo and tab-alignment

I would suggest always running portfmt after making any changes to Makefiles. This way, you would almost never worry about tabs/spaces, line wraps, etc.

haraldei added a comment.Sep 4 2026, 11:36 AM
In D59304#1361527, @vsasjason_gmail.com wrote:
In D59304#1361038, @haraldei wrote:

Fix typo and tab-alignment

I would suggest always running portfmt after making any changes to Makefiles. This way, you would almost never worry about tabs/spaces, line wraps, etc.

Thanks, I'm still a bit bewildered by the many tools, but I'll try to remember this one :)

jrm accepted this revision.Tue, Sep 8, 2:16 PM
This revision is now accepted and ready to land.Tue, Sep 8, 2:16 PM

Revision Contents
Changeset List

PathSize
java/
openjdk25/
37 lines
openjdk26/
38 lines

Diff 185617

View Options

java/openjdk25/Makefile

Loading...
View Options

java/openjdk26/Makefile

Loading...