Page MenuHomeFreeBSD

java/openjdk{25,26}: portclippy and cleanup
AcceptedPublic

Authored by haraldei on Tue, Sep 1, 1:50 PM.
Tags
None
Referenced Files
F172841619: D59304.diff
Mon, Sep 21, 12:04 PM
Unknown Object (File)
Tue, Sep 15, 9:45 AM
Unknown Object (File)
Mon, Sep 14, 9:38 PM
Unknown Object (File)
Mon, Sep 14, 6:42 AM
Unknown Object (File)
Sun, Sep 13, 9:06 PM
Unknown Object (File)
Sat, Sep 12, 9:17 AM
Unknown Object (File)
Sat, Sep 12, 8:34 AM
Unknown Object (File)
Sat, Sep 12, 5:20 AM
Subscribers
None

Details

Summary

Just a cleanup commit sorting the Makefile according to portclippy
suggestions, and reducing the number of times we check for a headless
build, as suggested by vsasjason_gmail.com.

This commit does not increase the PORTREVISION as it does not introduce
any changes to functionality or dependencies.

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 76403
Build 73286: arc lint + arc unit

Event Timeline

haraldei created this revision.
java/openjdk25/Makefile
43

typo: s/Jave/Java/

62–63

You need a TAB instead of spaces after the = here.

java/openjdk26/Makefile
43

typo: s/Jave/Java/

50–51

Two consecutive blank lines here.

62–63

You need a TAB instead of spaces after the = here.

Fix typo and tab-alignment

I would suggest always running portfmt after making any changes to Makefiles. This way, you would almost never worry about tabs/spaces, line wraps, etc.

Fix typo and tab-alignment

I would suggest always running portfmt after making any changes to Makefiles. This way, you would almost never worry about tabs/spaces, line wraps, etc.

Thanks, I'm still a bit bewildered by the many tools, but I'll try to remember this one :)

This revision is now accepted and ready to land.Tue, Sep 8, 2:16 PM