cat: add -A, -E and -T flags
ClosedPublic
Actions

Authored by bapt on Fri, Aug 28, 3:49 PM.

Details

Reviewers

Commits

rGd8c4785e1e41: cat: add -A, -E and -T flags
rGd2cfdf4c12a7: cat: add -A, -E and -T flags

Summary

Support cat -A, -E and -T, which are commonly used by Linux shell
scripts. -E prints a "$" at the end of each line, -T renders tabs
as ^I, and -A is equivalent to -vET.

Discussed with: jrtc27

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 76277
Build 73160: arc lint + arc unit

Event Timeline

bapt created this revision.Fri, Aug 28, 3:49 PM

Herald added subscribers: ziaee, imp. · View Herald TranscriptFri, Aug 28, 3:49 PM

bapt requested review of this revision.Fri, Aug 28, 3:49 PM

Harbormaster completed remote builds in B76277: Diff 185352.Fri, Aug 28, 3:49 PM

bapt added a reviewer: jrtc27.Fri, Aug 28, 3:50 PM

ziaee added inline comments.Fri, Aug 28, 4:04 PM

bin/cat/cat.1
87	Please move this after line 80 for alphasort
bin/cat/cat.c
169	Can this be moved to after 165 for alphasort?
175	Can this be moved to after line 171 for alphasort?
190	Can this be moved to after line 186 for alphasort? The reason is because whenever I have manuals where the options are jumbled up, the code also has jumbled up options.
bin/cat/tests/cat_extra_test.sh
6	Silly nit: I think you have an extra "#" here.