Page MenuHomeFreeBSD
Differential D59203

video: add V4L2 cropping, control menu and overlay symbols
ClosedPublic
Actions

Authored by seuros on Wed, Aug 26, 9:54 PM.
Tags
Referenced Files
F172552425: D59203.id185236.diff
Sat, Sep 19, 5:21 AM
Unknown Object (File)
Fri, Sep 18, 2:47 AM
Unknown Object (File)
Thu, Sep 17, 3:29 PM
Unknown Object (File)
Thu, Sep 17, 3:29 PM
Unknown Object (File)
Thu, Sep 17, 3:20 PM
Unknown Object (File)
Thu, Sep 17, 10:58 AM
Unknown Object (File)
Thu, Sep 17, 7:22 AM
Unknown Object (File)
Mon, Sep 14, 6:34 AM
View All 82 Files
Subscribers
imp

Details

Reviewers
thierry
adrian
Commits
rGd5016a820414: video: add V4L2 cropping, control menu and overlay symbols
Summary

Adds missing structs symbols for V4L2.

video(4) capture devices do not crop, expose menu controls or support
overlay, and return ENOTTY for the new ioctls.
Applications enumerate these unconditionally and degrade gracefully
at run time, but fail to build when the declarations are missing.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 76195
Build 73078: arc lint + arc unit

Event Timeline

seuros created this revision.Wed, Aug 26, 9:54 PM
Herald added a subscriber: imp. · View Herald TranscriptWed, Aug 26, 9:54 PM
seuros requested review of this revision.Wed, Aug 26, 9:54 PM
Harbormaster completed remote builds in B76195: Diff 185171.Wed, Aug 26, 9:54 PM
seuros added a project: drivers.Wed, Aug 26, 9:55 PM
seuros edited the summary of this revision. (Show Details)
thierry added a comment.Thu, Aug 27, 7:56 AM

LGTM. Please also bump OSVERSION, so that ports can test it.

seuros added a comment.Thu, Aug 27, 9:38 AM

I'm adding the OSVersion bump in a separate diff.

I will land them once @adrian approve both

seuros added a child revision: D59208: video: bump __FreeBSD_version for V4L2 cropping and overlay symbols.Thu, Aug 27, 9:57 AM
adrian accepted this revision.Thu, Aug 27, 4:02 PM

make sure you do a "make universe" on a beefy enough machine to try and capture any of the weird kernel variants having different sizes.

This revision is now accepted and ready to land.Thu, Aug 27, 4:02 PM
Closed by commit rGd5016a820414: video: add V4L2 cropping, control menu and overlay symbols (authored by seuros). · Explain WhyThu, Aug 27, 7:05 PM
This revision was automatically updated to reflect the committed changes.
seuros added a commit: rGd5016a820414: video: add V4L2 cropping, control menu and overlay symbols.
thierry mentioned this in R11:f1094a876652: multimedia/lebiniou: fix on -CURRENT with video(4).Wed, Sep 2, 4:34 PM

Revision Contents
Changeset List

PathSize
sys/
sys/
73 lines

Diff 185171

View Options

sys/sys/videoio.h

Loading...