Page MenuHomeFreeBSD
Differential D59107

rtwn: allow non-zero interface indexes
ClosedPublic
Actions

Authored by vexeduxr on Fri, Aug 21, 11:42 PM.
Tags
Referenced Files
F167953634: D59107.diff
Tue, Aug 25, 2:50 PM
F167916205: D59107.id.diff
Tue, Aug 25, 10:17 AM
Unknown Object (File)
Mon, Aug 24, 4:15 AM
Unknown Object (File)
Mon, Aug 24, 2:00 AM
Unknown Object (File)
Sun, Aug 23, 11:19 PM
Unknown Object (File)
Sun, Aug 23, 5:23 PM
Unknown Object (File)
Sat, Aug 22, 8:33 PM
Unknown Object (File)
Sat, Aug 22, 8:10 PM
View All 10 Files
Subscribers
imp

Details

Reviewers
adrian
avos
kevlo
Group Reviewers
wireless
Commits
rG481314f620ac: rtwn: allow non-zero interface indexes
Summary

The endpoints we want won't always be on interface 0. Instead, allow the
interface index to be specified in driver_info when probing.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 75961
Build 72844: arc lint + arc unit

Event Timeline

vexeduxr created this revision.Fri, Aug 21, 11:42 PM
Herald added a subscriber: imp. · View Herald TranscriptFri, Aug 21, 11:42 PM
vexeduxr requested review of this revision.Fri, Aug 21, 11:42 PM
Harbormaster completed remote builds in B75961: Diff 184707.Fri, Aug 21, 11:42 PM
vexeduxr added a parent revision: D59106: rtwn: add rtwn_efuse_preread.Fri, Aug 21, 11:42 PM
bz resigned from this revision.Sat, Aug 22, 12:05 AM
bz edited reviewers, added: wireless; removed: bz.
adrian added projects: drivers, wireless.Sun, Aug 23, 1:48 AM

which devices have you tested this on? You should add that list to the commit message.

Other than that this looks fine to me.

adrian added a comment.Sun, Aug 23, 1:48 AM

same a the previous one; what devices have you tested this with?
It'd be good to know that it doesn't break any of the current rtwn USB devices.
(I'll try it myself locally tonight.)

adrian added a comment.Sun, Aug 23, 4:41 PM

Locally tested on RTL8821AU . We should test it on a few more just to make sure it's okay.

adrian added a comment.Sun, Aug 23, 4:45 PM

Tested on RTL8192CU and RTL8188CUS as well. Probe/attach is fine for these two diffs.

vexeduxr added a comment.Sun, Aug 23, 4:45 PM
In D59107#1356069, @adrian wrote:

Locally tested on RTL8821AU . We should test it on a few more just to make sure it's okay.

I tested it on the RTL8188EU. I'll add these two to the commit message.

Thanks!

adrian accepted this revision.Sun, Aug 23, 4:46 PM
This revision is now accepted and ready to land.Sun, Aug 23, 4:46 PM
Closed by commit rG481314f620ac: rtwn: allow non-zero interface indexes (authored by vexeduxr, committed by adrian). · Explain WhySun, Aug 23, 4:49 PM
This revision was automatically updated to reflect the committed changes.
adrian added a commit: rG481314f620ac: rtwn: allow non-zero interface indexes.

Revision Contents
Changeset List

PathSize
sys/
dev/
rtwn/
usb/
15 lines
14 lines
3 lines
3 lines
6 lines

Diff 184707

View Options

sys/dev/rtwn/usb/rtwn_usb_attach.h

Loading...
View Options

sys/dev/rtwn/usb/rtwn_usb_attach.c

Loading...
View Options

sys/dev/rtwn/usb/rtwn_usb_ep.h

Loading...
View Options

sys/dev/rtwn/usb/rtwn_usb_ep.c

Loading...
View Options

sys/dev/rtwn/usb/rtwn_usb_var.h

Loading...