Page MenuHomeFreeBSD
Differential D59107

rtwn: allow non-zero interface indexes
Needs ReviewPublic
Actions

Authored by vexeduxr on Fri, Aug 21, 11:42 PM.
Tags
Referenced Files
F167579675: D59107.id.diff
Sat, Aug 22, 8:33 PM
F167577797: D59107.diff
Sat, Aug 22, 8:10 PM
F167511833: D59107.id184707.diff
Sat, Aug 22, 9:39 AM
F167511646: D59107.diff
Sat, Aug 22, 9:37 AM
Subscribers
imp

Details

Reviewers
adrian
avos
kevlo
Group Reviewers
wireless
Summary

The endpoints we want won't always be on interface 0. Instead, allow the
interface index to be specified in driver_info when probing.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 75961
Build 72844: arc lint + arc unit

Event Timeline

vexeduxr created this revision.Fri, Aug 21, 11:42 PM
Herald added a subscriber: imp. · View Herald TranscriptFri, Aug 21, 11:42 PM
vexeduxr requested review of this revision.Fri, Aug 21, 11:42 PM
Harbormaster completed remote builds in B75961: Diff 184707.Fri, Aug 21, 11:42 PM
vexeduxr added a parent revision: D59106: rtwn: add rtwn_efuse_preread.Fri, Aug 21, 11:42 PM
bz resigned from this revision.Sat, Aug 22, 12:05 AM
bz edited reviewers, added: wireless; removed: bz.
adrian added projects: drivers, wireless.Sun, Aug 23, 1:48 AM

which devices have you tested this on? You should add that list to the commit message.

Other than that this looks fine to me.

adrian added a comment.Sun, Aug 23, 1:48 AM

same a the previous one; what devices have you tested this with?
It'd be good to know that it doesn't break any of the current rtwn USB devices.
(I'll try it myself locally tonight.)

Revision Contents
Changeset List

PathSize
sys/
dev/
rtwn/
usb/
15 lines
14 lines
3 lines
3 lines
6 lines

Diff 184707

View Options

sys/dev/rtwn/usb/rtwn_usb_attach.h

Loading...
View Options

sys/dev/rtwn/usb/rtwn_usb_attach.c

Loading...
View Options

sys/dev/rtwn/usb/rtwn_usb_ep.h

Loading...
View Options

sys/dev/rtwn/usb/rtwn_usb_ep.c

Loading...
View Options

sys/dev/rtwn/usb/rtwn_usb_var.h

Loading...