Page MenuHomeFreeBSD
Differential D59014

tests/sys/posixshm/posixshm_test.c::accounting fix after st_size changes
ClosedPublic
Actions

Authored by kib on Wed, Aug 19, 9:58 PM.
Tags
None
Referenced Files
F168808301: D59014.id184414.diff
Sun, Aug 30, 6:26 AM
F168799597: D59014.id.diff
Sun, Aug 30, 5:31 AM
F168736897: D59014.id184407.diff
Sat, Aug 29, 9:36 PM
F168725802: D59014.id184620.diff
Sat, Aug 29, 8:13 PM
F168719724: D59014.id184620.diff
Sat, Aug 29, 7:31 PM
Unknown Object (File)
Fri, Aug 28, 11:43 PM
Unknown Object (File)
Fri, Aug 28, 3:12 PM
Unknown Object (File)
Fri, Aug 28, 7:40 AM
View All 27 Files
Subscribers
imp

Details

Reviewers
markj
emaste
Commits
rGa1aa26b7db2c: tests/sys/posixshm/posixshm_test.c::accounting fix after st_size changes
Summary
st_blksize is defined by POSIX as the 'preferred I/O block size for this
object.' It is wrong to use st_blksize as the unit for st_blocks and
expect it to be equal to the object size regardless of the change of
st_blksize.

Fixes:  3a1bf59d195c ("shmfd: consistently return size in 512 byte blocks for fstat(2) st_blocks")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.Wed, Aug 19, 9:58 PM
Herald added a subscriber: imp. · View Herald TranscriptWed, Aug 19, 9:58 PM
kib requested review of this revision.Wed, Aug 19, 9:58 PM
kib updated this revision to Diff 184407.

Commit all chunks

kib updated this revision to Diff 184414.Wed, Aug 19, 11:15 PM

Cosmetics: use ATF_CHECK_EQ instead of ATF_REQUIRE for size comparison.
Add debugging printfs to make debugging tests not so painful.

markj accepted this revision.Thu, Aug 20, 12:47 PM
This revision is now accepted and ready to land.Thu, Aug 20, 12:47 PM
Closed by commit rGa1aa26b7db2c: tests/sys/posixshm/posixshm_test.c::accounting fix after st_size changes (authored by kib). · Explain WhyFri, Aug 21, 1:32 AM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rGa1aa26b7db2c: tests/sys/posixshm/posixshm_test.c::accounting fix after st_size changes.

Revision Contents
Changeset List

PathSize
tests/
sys/
posixshm/
8 lines

Diff 184620

View Options

tests/sys/posixshm/posixshm_test.c

Loading...